Skip to content

mock API: Move floating IP checks earlier in instance create handler #2466

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
david-crespo merged 1 commit into from
Oct 3, 2024
Merged

mock API: Move floating IP checks earlier in instance create handler #2466

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
58 changes: 41 additions & 17 deletions mock-api/msw/handlers.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -448,9 +448,33 @@ export const handlers = makeHandlers({
})
}

/////////////////////////////////////////////////////////////
// DB write stuff starts here
/////////////////////////////////////////////////////////////
// validate floating IP attachments before we actually do anything
body.external_ips?.forEach((ip) => {
if (ip.type === 'floating') {
// throw if floating IP doesn't exist
const floatingIp = lookup.floatingIp({
project: project.id,
floatingIp: ip.floating_ip,
})
if (floatingIp.instance_id) {
throw 'floating IP cannot be attached to one instance while still attached to another'
}
} else {
// just make sure we can get one. technically this will only throw
// if there are no ranges in the pool or if the pool doesn't exist,
// which aren't quite as good as checking that there are actually IPs
// available, but they are good things to check
getIpFromPool(ip.pool)
}
})

//////////////////////////////////////////////////////////////////////////
// DB WRITES START HERE
//
// We don't have transactions or sagas, so we need to make sure we do all
// our validation and throw any errors about bad input before we make any
// changes to the DB that would have to be undone on failure.
//////////////////////////////////////////////////////////////////////////

for (const diskParams of allDisks) {
if (diskParams.type === 'create') {
Expand Down Expand Up @@ -515,26 +539,15 @@ export const handlers = makeHandlers({
)
}

const newInstance: Json<Api.Instance> = {
id: instanceId,
project_id: project.id,
...R.pick(body, ['name', 'description', 'hostname', 'memory', 'ncpus']),
...getTimestamps(),
run_state: 'creating',
time_run_state_updated: new Date().toISOString(),
boot_disk_id: bootDiskId,
auto_restart_enabled: true,
}

// actually set up IPs. looks very similar to validation step but this time
// we are writing to the DB
body.external_ips?.forEach((ip) => {
if (ip.type === 'floating') {
const floatingIp = lookup.floatingIp({
project: project.id,
floatingIp: ip.floating_ip,
})
if (floatingIp.instance_id) {
throw 'floating IP cannot be attached to one instance while still attached to another'
}
// we've already validated that the IP isn't attached
floatingIp.instance_id = instanceId
} else if (ip.type === 'ephemeral') {
const firstAvailableAddress = getIpFromPool(ip.pool)
Expand All @@ -548,6 +561,17 @@ export const handlers = makeHandlers({
}
})

const newInstance: Json<Api.Instance> = {
id: instanceId,
project_id: project.id,
...R.pick(body, ['name', 'description', 'hostname', 'memory', 'ncpus']),
...getTimestamps(),
run_state: 'creating',
time_run_state_updated: new Date().toISOString(),
boot_disk_id: bootDiskId,
auto_restart_enabled: true,
}

setTimeout(() => {
newInstance.run_state = 'starting'
}, 500)
Expand Down