Fix disableClear bug in Transit IP form; don't add duplicate IPs to list #2480
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
charliepark
changed the title
david-crespo
added a commit
that referenced
this pull request
Oct 1, 2024
Collaborator
david-crespo
added a commit
that referenced
this pull request
Oct 1, 2024
* move ip utils to their own file * validateIpNet util based one existing validateIp * let's try a more interesting result type on the validator * validate IPs and IP nets on the route form * redo validateIp to look more like validateIpNet, esp. including message * tweak validation logic to get more helpful messages, test it * validate transit IPs on network interface edit * split parse from validate, it's clean! * fix e2e failure but it raises existential questions * test leading zeroes in width * pass noop validate functions to comboboxes that get swapped with textfields * validate IPs, IP nets and names on firewall rules form * fix subform revalidation issue * really fix subform revalidation and test it like crazy * add test for transit IPs form, incorporate PR #2480 #2480 * validate transit ip dupes in validate function * tests that catch clear button bug, fix bug * have to do the reset on success effect for transit IPs too * test IP validation in route form * polish up last two todos to do two twos too
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found a bug in the logic on the disableClear button for the "add a transit IP" form — checking whether the field has anything in it gives a more reliable signal about whether it should be clearable or not. Also, I was able to add some logic to prevent duplication of IPs in the list.