Skip to content

Add truncation component to prevent table breakage #2503

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
charliepark merged 3 commits into from
Oct 11, 2024
Merged

Add truncation component to prevent table breakage #2503

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
abcf067
Add truncation component to prevent table breakage
charliepark Oct 11, 2024
4d1e65c
Add padding to right side of mini-table cell > div
charliepark Oct 11, 2024
581b365
Tighten up question icon button padding in header
charliepark Oct 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/components/DocsPopover.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ type DocsPopoverProps = {
export const DocsPopover = ({ heading, icon, summary, links }: DocsPopoverProps) => {
return (
<Popover>
<PopoverButton className={cn(buttonStyle({ size: 'sm', variant: 'ghost' }), 'w-9')}>
<PopoverButton className={cn(buttonStyle({ size: 'sm', variant: 'ghost' }), 'w-8')}>
<Question12Icon aria-label="Links to docs" className="shrink-0" />
</PopoverButton>
<PopoverPanel
Expand Down
5 changes: 4 additions & 1 deletion app/components/form/fields/DisksTableField.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ import type { InstanceCreateInput } from '~/forms/instance-create'
import { Badge } from '~/ui/lib/Badge'
import { Button } from '~/ui/lib/Button'
import * as MiniTable from '~/ui/lib/MiniTable'
import { Truncate } from '~/ui/lib/Truncate'
import { bytesToGiB } from '~/util/units'

export type DiskTableItem =
Expand Down Expand Up @@ -60,7 +61,9 @@ export function DisksTableField({
aria-label={`Name: ${item.name}, Type: ${item.type}`}
key={item.name}
>
<MiniTable.Cell>{item.name}</MiniTable.Cell>
<MiniTable.Cell>
<Truncate text={item.name} maxLength={35} />
</MiniTable.Cell>
<MiniTable.Cell>
<Badge variant="solid">{item.type}</Badge>
</MiniTable.Cell>
Expand Down
2 changes: 1 addition & 1 deletion app/ui/styles/components/mini-table.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@
}

& td > div {
@apply flex h-11 items-center border-y py-3 pl-3 text-accent bg-accent-secondary border-accent-tertiary;
@apply flex h-11 items-center border-y py-3 pl-3 pr-6 text-accent bg-accent-secondary border-accent-tertiary;
}

& td:last-child > div {
Expand Down