Skip to content

Conversation

@charliepark
Copy link
Contributor

This adds the IP Pool description to the IP Pool dropdown visible to the end user on the silo …
Screenshot 2024-10-22 at 3 51 33 PM
http://localhost:4000/projects/mock-project/floating-ips-new

And adds a note to the IP Pool form …
Screenshot 2024-10-22 at 3 53 32 PM
http://localhost:4000/system/networking/ip-pools-new

Closes #2041
Closes #2042

@vercel
Copy link

vercel bot commented Oct 22, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
console ✅ Ready (Inspect) Visit Preview Oct 29, 2024 5:56pm

@charliepark
Copy link
Contributor Author

I added some vertical space to the combobox for the Select an Image dropdown as well:
Screenshot 2024-10-22 at 4 23 38 PM

@david-crespo
Copy link
Collaborator

Awesome, love it. We also need it on instance create, under advanced networking.

image

Also on attach ephemeral IP on instance networking tab (button only shows up when there's no ephemeral IP):

image

@charliepark
Copy link
Contributor Author

charliepark commented Oct 25, 2024

Crespo and I talked IRL and he pointed out that — since there won't be many pools — it probably makes sense for these to all be Listboxes, rather than Comboboxes. Still with the descriptions, though.

@david-crespo
Copy link
Collaborator

david-crespo commented Oct 28, 2024

The badge color needs a tweak when the item is selected. This might be kind of a pain. Needs to be done in CSS probably, like in menu-list.css.

Fine when not highlighted

Weird when highlighted

@charliepark
Copy link
Contributor Author

I'll work on something a bit more sophisticated via CSS, but this first stab could have been worse.
Screenshot 2024-10-28 at 3 45 13 PM
Screenshot 2024-10-28 at 3 47 18 PM
Screenshot 2024-10-28 at 3 47 28 PM
Screenshot 2024-10-28 at 3 47 37 PM

@charliepark
Copy link
Contributor Author

This wasn't actually bad at all.
badges

Copy link
Collaborator

@david-crespo david-crespo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome. I’ll leave it to @benjaminleonard to tweak the selected badge color if he wants.

@benjaminleonard
Copy link
Contributor

I've got it somewhere, not sure where of an example with the selected badge. But should be solid instead of dim.

Not sure if we have the accent solid variant as a class. But it might be easier to extract it out into its own class and then conditionally apply that instead? Then badgeColors is just applying that class.

@david-crespo
Copy link
Collaborator

It's nice to do it in CSS, otherwise the item has to be aware of whether it's selected.

@charliepark
Copy link
Contributor Author

Here's where we landed in chat:
Screenshot 2024-10-29 at 10 55 43 AM
Screenshot 2024-10-29 at 10 55 50 AM

@charliepark charliepark enabled auto-merge (squash) October 29, 2024 17:58
@charliepark charliepark merged commit df0dea4 into main Oct 29, 2024
7 checks passed
@charliepark charliepark deleted the ip-pool-descriptions branch October 29, 2024 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Display IP pool description on IP pool pickers Indicate to operator that IP pool description is visible to end users in linked silos

4 participants