-
Notifications
You must be signed in to change notification settings - Fork 18
Add descriptions to IP Pool dropdowns #2514
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Crespo and I talked IRL and he pointed out that — since there won't be many pools — it probably makes sense for these to all be Listboxes, rather than Comboboxes. Still with the descriptions, though. |
|
The badge color needs a tweak when the item is selected. This might be kind of a pain. Needs to be done in CSS probably, like in Fine when not highlighted
Weird when highlighted
|
david-crespo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome. I’ll leave it to @benjaminleonard to tweak the selected badge color if he wants.
|
I've got it somewhere, not sure where of an example with the selected badge. But should be solid instead of dim. Not sure if we have the accent solid variant as a class. But it might be easier to extract it out into its own class and then conditionally apply that instead? Then |
|
It's nice to do it in CSS, otherwise the item has to be aware of whether it's selected. |
oxidecomputer/console@f7d6daf...6eeab20 * [6eeab203](oxidecomputer/console@6eeab203) oxidecomputer/console#2525 * [bdc1c87c](oxidecomputer/console@bdc1c87c) oxidecomputer/console#2526 * [23824251](oxidecomputer/console@23824251) oxidecomputer/console#2508 * [78e7e26b](oxidecomputer/console@78e7e26b) oxidecomputer/console#2524 * [eb7f8567](oxidecomputer/console@eb7f8567) oxidecomputer/console#2504 * [df0dea4a](oxidecomputer/console@df0dea4a) oxidecomputer/console#2514 * [3474c6ce](oxidecomputer/console@3474c6ce) oxidecomputer/console#2522 * [af6a89e7](oxidecomputer/console@af6a89e7) oxidecomputer/console#2520 * [4e967560](oxidecomputer/console@4e967560) oxidecomputer/console#2512
oxidecomputer/console@f7d6daf...6eeab20 * [6eeab203](oxidecomputer/console@6eeab203) oxidecomputer/console#2525 * [bdc1c87c](oxidecomputer/console@bdc1c87c) oxidecomputer/console#2526 * [23824251](oxidecomputer/console@23824251) oxidecomputer/console#2508 * [78e7e26b](oxidecomputer/console@78e7e26b) oxidecomputer/console#2524 * [eb7f8567](oxidecomputer/console@eb7f8567) oxidecomputer/console#2504 * [df0dea4a](oxidecomputer/console@df0dea4a) oxidecomputer/console#2514 * [3474c6ce](oxidecomputer/console@3474c6ce) oxidecomputer/console#2522 * [af6a89e7](oxidecomputer/console@af6a89e7) oxidecomputer/console#2520 * [4e967560](oxidecomputer/console@4e967560) oxidecomputer/console#2512












This adds the IP Pool description to the IP Pool dropdown visible to the end user on the silo …

http://localhost:4000/projects/mock-project/floating-ips-new
And adds a note to the IP Pool form …

http://localhost:4000/system/networking/ip-pools-new
Closes #2041
Closes #2042