Skip to content

Fix dropdown z index #2522

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
charliepark merged 3 commits into from
Oct 28, 2024
Merged

Fix dropdown z index #2522

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c95a78e
Update zIndex to handle bottomBar and action menu stacking
charliepark Oct 28, 2024
6f6c854
clean up unnecessary classNames
charliepark Oct 28, 2024
3cc0931
Update app/ui/styles/components/menu-button.css
charliepark Oct 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/components/TopBar.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ export function TopBar({ children }: { children: React.ReactNode }) {
</span>
<DirectionDownIcon className="!w-2.5" />
</DropdownMenu.Trigger>
<DropdownMenu.Content gap={8} className="!z-topBarPopover">
<DropdownMenu.Content gap={8}>
<DropdownMenu.LinkItem to={pb.profile()}>Settings</DropdownMenu.LinkItem>
<DropdownMenu.Item onSelect={() => logout.mutate({})}>
Sign out
Expand Down
2 changes: 1 addition & 1 deletion app/components/TopBarPicker.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,7 @@ const TopBarPicker = (props: TopBarPickerProps) => {
{/* TODO: popover position should be further right */}
{props.items && (
<DropdownMenu.Content
className="!z-topBarPopover mt-2 max-h-80 min-w-[12.8125rem] overflow-y-auto"
className="mt-2 max-h-80 min-w-[12.8125rem] overflow-y-auto"
anchor="bottom start"
>
{props.items.length > 0 ? (
Expand Down
3 changes: 2 additions & 1 deletion app/ui/styles/components/menu-button.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,8 @@
*/

.DropdownMenuContent {
@apply z-popover min-w-36 rounded border p-0 bg-raise border-secondary;
/* we want menu popover to be on top of top bar and pagination bar too */
@apply z-topBarDropdown min-w-36 rounded border p-0 bg-raise border-secondary;

& .DropdownMenuItem {
@apply block w-full cursor-pointer select-none border-b py-2 pl-3 pr-6 text-left text-sans-md text-secondary border-secondary last:border-b-0;
Expand Down
2 changes: 1 addition & 1 deletion tailwind.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ module.exports = {
modal: '40',
sideModalDropdown: '40',
sideModal: '30',
topBarPopover: '25',
topBarDropdown: '25',
topBar: '20',
popover: '10',
contentDropdown: '10',
Expand Down
Loading