chore: convert last few routes #2719
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
david-crespo
added a commit
to oxidecomputer/omicron
that referenced
this pull request
Feb 28, 2025
oxidecomputer/console@dc4e0d4...a3566bd * [a3566bd2](oxidecomputer/console@a3566bd2) oxidecomputer/console#2719 * [251e7b70](oxidecomputer/console@251e7b70) put TS back to 5.7, turn off renovate automerge :( * [2ec0873c](oxidecomputer/console@2ec0873c) oxidecomputer/console#2715 * [69a171cf](oxidecomputer/console@69a171cf) oxidecomputer/console#2716 * [e9dafb37](oxidecomputer/console@e9dafb37) oxidecomputer/console#2717 * [efdcf3d8](oxidecomputer/console@efdcf3d8) oxidecomputer/console#2710 * [c09cbd70](oxidecomputer/console@c09cbd70) oxidecomputer/console#2713 * [8626af25](oxidecomputer/console@8626af25) chore: fix oxlint config
david-crespo
added a commit
to oxidecomputer/omicron
that referenced
this pull request
Mar 1, 2025
oxidecomputer/console@dc4e0d4...a3566bd * [a3566bd2](oxidecomputer/console@a3566bd2) oxidecomputer/console#2719 * [251e7b70](oxidecomputer/console@251e7b70) put TS back to 5.7, turn off renovate automerge :( * [2ec0873c](oxidecomputer/console@2ec0873c) oxidecomputer/console#2715 * [69a171cf](oxidecomputer/console@69a171cf) oxidecomputer/console#2716 * [e9dafb37](oxidecomputer/console@e9dafb37) oxidecomputer/console#2717 * [efdcf3d8](oxidecomputer/console@efdcf3d8) oxidecomputer/console#2710 * [c09cbd70](oxidecomputer/console@c09cbd70) oxidecomputer/console#2713 * [8626af25](oxidecomputer/console@8626af25) chore: fix oxlint config
david-crespo
added a commit
that referenced
this pull request
Mar 3, 2025
This backs out commit a3566bd.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2019
Biggest chunk of the bundle is now down to 170kb from around 400kb. That's pretty good.
Using
experimentalMinChunkSizein the rollup options keeps us from having 222 separate JS files, some of which would be tiny. We have 94. There could be fewer but this isn't that bad. Increasing the min chunk size doesn't actually make it merge all the small chunks for some reason — we can look into that later.Biggest chunk breakdown
Using the trusty
npx vite-bundle-visualizerwe can see the main bundle is down to pretty key stuff like React, React Router, Tanstack Query, Floating UI.