Page loading skeleton #2754
Page loading skeleton #2754
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Ok I just noticed on the preview that in MSW banner mode, we need the banner on the loading state, otherwise the grid doesn't line up when the page pops in. |
| </Route> | ||
|
|
||
| <Route index element={<Navigate to={pb.projects()} replace />} /> | ||
| <Route index loader={() => redirect(pb.projects())} /> |
There was a problem hiding this comment.
Without this, when loading the root (an extremely common thing to do) you'd see the skeleton flash and then it would go blank wile the loaders for the next route load. I think doing it this way is fine as long we never link to /, which we don't. We'll have to see if there's any weird behavior, though. I think another workaround would be to leave the element thing in place and give this route a loader that just calls the loader from the projects page, that way the loading time is spent with the fallback up.
oxidecomputer/console@eed4a4e...72e2f0c * [72e2f0c1](oxidecomputer/console@72e2f0c1) oxidecomputer/console#2754 * [af255e6b](oxidecomputer/console@af255e6b) bump omicron to latest main * [7cdb9ccb](oxidecomputer/console@7cdb9ccb) oxidecomputer/console#2753 * [27cf6799](oxidecomputer/console@27cf6799) oxidecomputer/console#2751 * [1cfb3b22](oxidecomputer/console@1cfb3b22) oxidecomputer/console#2752 * [6db63364](oxidecomputer/console@6db63364) oxidecomputer/console#2750 * [5241ad74](oxidecomputer/console@5241ad74) oxidecomputer/console#2748
oxidecomputer/console@eed4a4e...72e2f0c * [72e2f0c1](oxidecomputer/console@72e2f0c1) oxidecomputer/console#2754 * [af255e6b](oxidecomputer/console@af255e6b) bump omicron to latest main * [7cdb9ccb](oxidecomputer/console@7cdb9ccb) oxidecomputer/console#2753 * [27cf6799](oxidecomputer/console@27cf6799) oxidecomputer/console#2751 * [1cfb3b22](oxidecomputer/console@1cfb3b22) oxidecomputer/console#2752 * [6db63364](oxidecomputer/console@6db63364) oxidecomputer/console#2750 * [5241ad74](oxidecomputer/console@5241ad74) oxidecomputer/console#2748
Figured out how to do it and it is good. Closes #1569. In the video a show that we avoid showing the skeleton on login and device token verify pages that do not have the grid lines.
2025-03-13-skeleton.mp4