Fix metric loading and empty states #2779
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
charliepark
approved these changes
Apr 4, 2025
Contributor
|
I did spot this artifact on the left of the warning |
david-crespo
added a commit
to oxidecomputer/omicron
that referenced
this pull request
Apr 8, 2025
oxidecomputer/console@f52f50c...3e5a0a1 * [3e5a0a19](oxidecomputer/console@3e5a0a19) oxidecomputer/console#2775 * [ab06a337](oxidecomputer/console@ab06a337) oxidecomputer/console#2780 * [ae7a9899](oxidecomputer/console@ae7a9899) oxidecomputer/console#2782 * [e1d8077a](oxidecomputer/console@e1d8077a) oxidecomputer/console#2779 * [30b1afdd](oxidecomputer/console@30b1afdd) chore: npm audit fix (boring)
david-crespo
added a commit
to oxidecomputer/omicron
that referenced
this pull request
Apr 8, 2025
oxidecomputer/console@f52f50c...3e5a0a1 * [3e5a0a19](oxidecomputer/console@3e5a0a19) oxidecomputer/console#2775 * [ab06a337](oxidecomputer/console@ab06a337) oxidecomputer/console#2780 * [ae7a9899](oxidecomputer/console@ae7a9899) oxidecomputer/console#2782 * [e1d8077a](oxidecomputer/console@e1d8077a) oxidecomputer/console#2779 * [30b1afdd](oxidecomputer/console@30b1afdd) chore: npm audit fix (boring)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
isLoadingfrom React Query resultsTimeSeriesChart, distinct from loadinginput tables to group_by must be aligned#2738 by explicitly watching for the telltale error message and treating it as an empty success result insteadBefore (Empty results group by error)
After