Skip to content

Give silo and project access pages better titles #2793

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
david-crespo merged 1 commit into from
Apr 9, 2025
Merged

Give silo and project access pages better titles #2793

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions app/pages/SiloAccessPage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ export async function clientLoader() {
return null
}

export const handle = { crumb: 'Access' }
export const handle = { crumb: 'Silo Access' }

type UserRow = {
id: string
Expand Down Expand Up @@ -165,7 +165,7 @@ export default function SiloAccessPage() {
return (
<>
<PageHeader>
<PageTitle icon={<Access24Icon />}>Access</PageTitle>
<PageTitle icon={<Access24Icon />}>Silo Access</PageTitle>
<DocsPopover
heading="access"
icon={<Access16Icon />}
Expand Down
4 changes: 2 additions & 2 deletions app/pages/project/access/ProjectAccessPage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ export async function clientLoader({ params }: LoaderFunctionArgs) {
return null
}

export const handle = { crumb: 'Access' }
export const handle = { crumb: 'Project Access' }

type UserRow = {
id: string
Expand Down Expand Up @@ -204,7 +204,7 @@ export default function ProjectAccessPage() {
return (
<>
<PageHeader>
<PageTitle icon={<Access24Icon />}>Access</PageTitle>
<PageTitle icon={<Access24Icon />}>Project Access</PageTitle>
<DocsPopover
heading="access"
icon={<Access16Icon />}
Expand Down
4 changes: 2 additions & 2 deletions app/util/__snapshots__/path-builder.spec.ts.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -431,7 +431,7 @@ exports[`breadcrumbs 2`] = `
"path": "/projects/p/instances",
},
{
"label": "Access",
"label": "Project Access",
"path": "/projects/p/access",
},
],
Expand Down Expand Up @@ -539,7 +539,7 @@ exports[`breadcrumbs 2`] = `
],
"siloAccess (/access)": [
{
"label": "Access",
"label": "Silo Access",
"path": "/access",
},
],
Expand Down
Loading