Move IP Address column in Internet Gateways table #2839
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
charliepark
commented
Jun 16, 2025
| await Promise.all([ | ||
| ...gateways.items.flatMap((gateway: InternetGateway) => [ | ||
| queryClient.prefetchQuery( | ||
| queryClient.fetchQuery( |
Contributor
Author
There was a problem hiding this comment.
General prefetchQuery → fetchQuery migration discussed in 2616
david-crespo
approved these changes
Jun 22, 2025
Collaborator
david-crespo
left a comment
david-crespo
left a comment
There was a problem hiding this comment.
Approving this as a small net improvement but I'm still really unsatisfied with the presentation, so maybe we shouldn't close #2831, or maybe we should make a new issue for general clarification on this page. It's still hard to guess from the console or the docs how any of this works (example below from my chat with Kyle of the background I consider missing, linked in #2831). I might feel better about the console if the docs were better.
david-crespo
added a commit
to oxidecomputer/omicron
that referenced
this pull request
Jul 18, 2025
oxidecomputer/console@e891f96...8c54bea * [8c54bea3](oxidecomputer/console@8c54bea3) oxidecomputer/console#2850 * [a78eac9e](oxidecomputer/console@a78eac9e) oxidecomputer/console#2858 * [320a6c41](oxidecomputer/console@320a6c41) chore: playwright 1.54 * [e0890d02](oxidecomputer/console@e0890d02) oxidecomputer/console#2853 * [3da27b7e](oxidecomputer/console@3da27b7e) oxidecomputer/console#2838 * [99120cdf](oxidecomputer/console@99120cdf) tools: jeeves -> castle in dogfood deploy script * [eb7a44ea](oxidecomputer/console@eb7a44ea) oxidecomputer/console#2844 * [0ee6a973](oxidecomputer/console@0ee6a973) oxidecomputer/console#2845 * [837d6aa2](oxidecomputer/console@837d6aa2) oxidecomputer/console#2840 * [c5c0f3db](oxidecomputer/console@c5c0f3db) oxidecomputer/console#2843 * [83a47614](oxidecomputer/console@83a47614) oxidecomputer/console#2841 * [cdb9f736](oxidecomputer/console@cdb9f736) oxidecomputer/console#2836 * [06c2e727](oxidecomputer/console@06c2e727) oxidecomputer/console#2839 * [e71c8282](oxidecomputer/console@e71c8282) oxidecomputer/console#2835 * [5f338ce8](oxidecomputer/console@5f338ce8) oxidecomputer/console#2811
david-crespo
added a commit
to oxidecomputer/omicron
that referenced
this pull request
Jul 18, 2025
oxidecomputer/console@e891f96...8c54bea * [8c54bea3](oxidecomputer/console@8c54bea3) oxidecomputer/console#2850 * [a78eac9e](oxidecomputer/console@a78eac9e) oxidecomputer/console#2858 * [320a6c41](oxidecomputer/console@320a6c41) chore: playwright 1.54 * [e0890d02](oxidecomputer/console@e0890d02) oxidecomputer/console#2853 * [3da27b7e](oxidecomputer/console@3da27b7e) oxidecomputer/console#2838 * [99120cdf](oxidecomputer/console@99120cdf) tools: jeeves -> castle in dogfood deploy script * [eb7a44ea](oxidecomputer/console@eb7a44ea) oxidecomputer/console#2844 * [0ee6a973](oxidecomputer/console@0ee6a973) oxidecomputer/console#2845 * [837d6aa2](oxidecomputer/console@837d6aa2) oxidecomputer/console#2840 * [c5c0f3db](oxidecomputer/console@c5c0f3db) oxidecomputer/console#2843 * [83a47614](oxidecomputer/console@83a47614) oxidecomputer/console#2841 * [cdb9f736](oxidecomputer/console@cdb9f736) oxidecomputer/console#2836 * [06c2e727](oxidecomputer/console@06c2e727) oxidecomputer/console#2839 * [e71c8282](oxidecomputer/console@e71c8282) oxidecomputer/console#2835 * [5f338ce8](oxidecomputer/console@5f338ce8) oxidecomputer/console#2811
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves the
Attached IP Addresscolumn to come after theAttached IP Poolcolumn, and adds a header with explanatory text.Relates to #2831, but, per Crespo's comments below, does not fully address the root issue.