Show size of attached disks in mini table #2842
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
| onChange([ | ||
| ...items, | ||
| { name, type: 'attach', size: allDisks.find((d) => d.name === name)?.size }, | ||
| ]) |
Collaborator
There was a problem hiding this comment.
Unfortunately onChange has type (...event: any[]) => void, which masks a kind of type error here: size has type number on DiskTableItem, but here it is number | undefined. You can see this by adding satisfies DiskTableItem, which is annoying but the best way I can think of to deal with this.
Rather than pulling the size here from the name, it can be done inside AttachDiskModalForm because you know that you have the disk on hand there, otherwise it would not show up in the combobox. I made the change already in order to test it out, so I'll just push that.
david-crespo
added a commit
that referenced
this pull request
Jun 30, 2025
* Add data minitable component * Remove unnecessary var * Fix test * `rowLabel` and `onRemoveItem` not optional * rename render to cell like react table * remove rowLabel prop, not needed * last few tweaks * convert firewall rules minitable * convert the rest of the minitables (opencode) * rename DataMiniTable to MiniTable * let MiniTable hide itself * Show size of attached disks in mini table (#2842) * Show size of attached disks in mini table * update test * get disk size more directly --------- Co-authored-by: David Crespo <david.crespo@oxidecomputer.com> --------- Co-authored-by: David Crespo <david.crespo@oxidecomputer.com> Co-authored-by: Charlie Park <charlie@oxidecomputer.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds in a fix for #1662, where we aren't showing the size of the attached disks in the disks minitable.
As this isn't necessary for the
data-minitablebranch, I'm happy to wait until that branch is merged and I can merge this to main, but if you want to include it in the branch, it's available.Closes #1662.