[crucible-agent] migrate to API trait #1766
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Created using spr 1.3.6-beta.1
26 tasks
jmpesp
requested changes
Aug 28, 2025
agent/src/datafile.rs
Outdated
|
|
||
| use super::model::*; | ||
| use anyhow::{anyhow, bail, Result}; | ||
| use crucible_agent_types::region::*; |
There was a problem hiding this comment.
I'd have preferred to keep this as "model", as not all the types in there reference regions.
There was a problem hiding this comment.
Hmm, so I didn't want to call it crucible_agent_types::model because types and model are redundant with each other. What if I move SmfProperty into its own smf module?
There was a problem hiding this comment.
Created snapshot and smf modules.
agent/src/main.rs
Outdated
| // what will be used by other zones. In the future this could be a | ||
| // parameter that comes along with the region POST parameters. | ||
| properties.push(crate::model::SmfProperty { | ||
| properties.push(region::SmfProperty { |
There was a problem hiding this comment.
for example, SmfProperty has nothing to do with regions
Created using spr 1.3.6-beta.1
jmpesp
approved these changes
Sep 3, 2025
sunshowers
deleted the
sunshowers/spr/crucible-agent-migrate-to-api-trait
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of oxidecomputer/omicron#8922.