Skip to content

update omicron-common and other dependencies #1778

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Oct 7, 2025
Merged

update omicron-common and other dependencies #1778

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
4430c59
[spr] initial version
sunshowers Oct 2, 2025
e92afa4
try again
sunshowers Oct 2, 2025
c51e35b
also update rust-toolchain
sunshowers Oct 2, 2025
07fd6c2
pass in -y
sunshowers Oct 2, 2025
c179455
pass in tokio_unstalbe
sunshowers Oct 3, 2025
ff95219
fix all issues (sorry for the size)
sunshowers Oct 3, 2025
c6ddbac
rustfmt
sunshowers Oct 3, 2025
829a8af
fix tests
sunshowers Oct 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion .cargo/config.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,4 +6,6 @@ xtask = "run --package xtask --"
#
# Once https://github.com/rust-lang/cargo/issues/12115 makes it to our
# toolchain, we'll be able to put this in the `Cargo.toml` manifest instead.
rustflags = ["-Wclippy::unused-async"]
#
# Also enable the `tokio-unstable` config for `tokio-dtrace` probes.
rustflags = ["-Wclippy::unused-async", "--cfg", "tokio_unstable"]
3 changes: 3 additions & 0 deletions .github/buildomat/jobs/build-release.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,9 @@ pfexec coreadm -i /tmp/core.%f.%p \
-e log \
-e proc-setid \
-e global-setid

banner prerequisites
ptime -m ./tools/install_builder_prerequisites.sh -y
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why do we need this now?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One of the updates pulls in aws-lc-sys, which has a dependency on libclang :(

See this output.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From DMs - aws-lc-sys comes via tough, which comes via nexus-types, which crucible has due to using nexus-client


banner rbuild
ptime -m cargo build --verbose --release --all-features
Expand Down
3 changes: 3 additions & 0 deletions .github/buildomat/jobs/build.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,9 @@ pfexec coreadm -i /tmp/core.%f.%p \
-e proc-setid \
-e global-setid

banner prerequisites
ptime -m ./tools/install_builder_prerequisites.sh -y

banner build
ptime -m cargo build --verbose --all-features

Expand Down
Loading