32-way ecmp fanout. ecmp support for IPv6. #110
Conversation
|
Notes:
|
rcgoodfellow
left a comment
rcgoodfellow
left a comment
There was a problem hiding this comment.
Thanks Nils. LGTM just a few small comments. I think we'll also want to determine what the distribution looks like for the masked CRC8 so that is a known characteristic of the design.
| meta.l4_dst_port, | ||
| meta.l4_src_port | ||
| }); | ||
| }) & 0x3f; |
There was a problem hiding this comment.
Can you add a comment on the bit trading taking place through this mask (and for v6 below).
There was a problem hiding this comment.
Done. Noted in the ipv6 path as well.
dpd/src/table/route_ipv6.rs
Outdated
| .map(|_| info!(s.log, "deleted ipv6 index"; "route" => %cidr)) | ||
| .map_err(|e| { | ||
| error!(s.log, "failed to delete ipv6 index"; | ||
| "route" => %cidr, |
There was a problem hiding this comment.
Something a bit wonky with the formatting here. And several spots below.
A ran a test with a billion samples. Source and destination IPs were random within the 10.x.x.x subnet, and source and destination ports were random between 1000 and 10000. With the masked crc, there were 64 possible buckets into which these samples could land. The resulting bucket sizes looked like: min: 15615310 max: 15634865 avg: 15625000 std_dev: 4071.0562 cv: 0.0002605476 |
ecmp support for IPv6
No description provided.