Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dropshot] improve doc organization #1181

Merged
merged 3 commits into from
Nov 26, 2024

Conversation

sunshowers
Copy link
Contributor

In the review for #1171 I realized that we were specifying the endpoint
attribute params in two places, neither of which had a complete list. Put it
all in one place: on documentation for the proc macro.

Also move the documentation to dropshot/src/lib.rs to allow doctests to work.

Created using spr 1.3.6-beta.1

[skip ci]
Created using spr 1.3.6-beta.1
@sunshowers sunshowers changed the base branch from sunshowers/spr/main.dropshot-improve-doc-organization to main November 22, 2024 03:20
Created using spr 1.3.6-beta.1
Copy link
Collaborator

@ahl ahl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@sunshowers sunshowers merged commit 802f5bd into main Nov 26, 2024
10 checks passed
@sunshowers sunshowers deleted the sunshowers/spr/dropshot-improve-doc-organization branch November 26, 2024 22:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants