Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #150
These can arise because the schemars ignores conflicting names and
doesn't use e.g. the mod to qualify the name when necessary. There are
other errors that can result from this such as overwritten types, but
this is the most acute at the moment.
@smklein I don't think this is a great solution, but it may actually be what we want. There an issue in schemars that describes the problem of name conflicts more generally. In this case, however, we actually don't want two types in the schema and
#[serde(transparent)]
does exactly what we want.I'm not sure why serde (and schemars) don't do this automatically when they see
#[repr(transparent)]
but it may be that derive macros don't reliably see that attribute. See also serde-rs/serde#1054