ringbuf: make macros vestigial #1753
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/!\ EXTREMELY SERIOUS WARNING /!\
This will break Humility. Eliza, REMEMBER TO
UPDATE HUMILITY if you end up merging
this PR!!!!
This branch makes the
ringbufcrate usable without macros. Now, the macros are just very thin wrappers aroundRingbuf::new()const fn constructors and__RINGBUF.record(entry), respectively. The idea being that, should we decide this is worth doing, we could then incrememtally replace the uses of macros with normal method calls.