Skip to content

Read SP task crash dumps over the network #1921

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 16 commits into from
Dec 10, 2024
Merged

Read SP task crash dumps over the network #1921

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
077b380
Add helper function to read dump data into a lease
mkeeter Nov 13, 2024
e49195e
Cache dump area lookup
mkeeter Nov 13, 2024
6765f85
Implement reading task crash dumps over MGS
mkeeter Nov 13, 2024
c9a0949
Switch to upstream MGS
mkeeter Nov 18, 2024
31fe933
Fix priorities
mkeeter Nov 18, 2024
8cc044f
Clippy fixes
mkeeter Nov 18, 2024
1ef84cb
Fix LPC55xpresso build
mkeeter Nov 18, 2024
692313c
Remove debug trace
mkeeter Nov 18, 2024
186f89b
Fix typo
mkeeter Nov 19, 2024
24ce008
Add comment about accelerator
mkeeter Nov 19, 2024
0131baa
Add constants for size_of stuff
mkeeter Nov 20, 2024
bfb549f
Support UUID + sequence number
mkeeter Nov 19, 2024
fde6b2e
Move clear_client_state call to a single place
mkeeter Nov 20, 2024
9ec159d
Fix sidecar and PSC build
mkeeter Nov 20, 2024
23cedec
Updates per review
mkeeter Dec 10, 2024
a7ef633
Switch back to gateway-messages `master`
mkeeter Dec 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

7 changes: 4 additions & 3 deletions app/gimlet/base.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -230,7 +230,7 @@ name = "task-host-sp-comms"
features = ["stm32h753", "uart7", "baud_rate_3M", "hardware_flow_control", "vlan", "gimlet"]
uses = ["uart7", "dbgmcu"]
interrupts = {"uart7.irq" = "usart-irq"}
priority = 7
priority = 8
max-sizes = {flash = 65536, ram = 65536}
stacksize = 5080
start = true
Expand Down Expand Up @@ -259,14 +259,15 @@ notifications = ["socket"]

[tasks.control_plane_agent]
name = "task-control-plane-agent"
priority = 6
priority = 7
max-sizes = {flash = 131072, ram = 32768}
# This can probably overkill and can be tuned later
stacksize = 6000
start = true
uses = ["usart1"]
task-slots = [
"jefe",
"dump_agent",
"net",
"update_server",
"sys",
Expand Down Expand Up @@ -348,7 +349,7 @@ stacksize = 800

[tasks.idle]
name = "task-idle"
priority = 8
priority = 9
max-sizes = {flash = 128, ram = 256}
stacksize = 256
start = true
Expand Down
1 change: 1 addition & 0 deletions app/gimletlet/app.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,7 @@ uses = ["usart1"]
task-slots = [
"jefe",
"net",
"dump_agent",
"update_server",
"sys",
"hf",
Expand Down
5 changes: 3 additions & 2 deletions app/grapefruit/app.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -211,7 +211,7 @@ name = "task-host-sp-comms"
features = ["stm32h753", "usart6", "baud_rate_3M", "hardware_flow_control", "vlan", "grapefruit"]
uses = ["usart6", "dbgmcu"]
interrupts = {"usart6.irq" = "usart-irq"}
priority = 7
priority = 8
max-sizes = {flash = 65536, ram = 65536}
stacksize = 5080
start = true
Expand All @@ -220,14 +220,15 @@ notifications = ["jefe-state-change", "usart-irq", "multitimer", "control-plane-

[tasks.control_plane_agent]
name = "task-control-plane-agent"
priority = 6
priority = 7
max-sizes = {flash = 131072, ram = 32768}
# This can probably overkill and can be tuned later
stacksize = 6000
start = true
uses = ["usart1"]
task-slots = [
"auxflash",
"dump_agent",
"jefe",
"net",
"update_server",
Expand Down
2 changes: 1 addition & 1 deletion app/lpc55xpresso/app.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,7 +132,7 @@ task-slots = ["user_leds"]
name = "task-dump-agent"
features = ["no-rot"]
priority = 5
max-sizes = {flash = 32768, ram = 2240 }
max-sizes = {flash = 32768, ram = 2272 }
start = true
task-slots = ["jefe"]
stacksize = 1536
Expand Down
5 changes: 3 additions & 2 deletions app/psc/base.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -195,14 +195,15 @@ notifications = ["spi-irq"]

[tasks.control_plane_agent]
name = "task-control-plane-agent"
priority = 5
priority = 6
max-sizes = {flash = 131072, ram = 32768}
# This is probably a bit overkill and can be tuned later
stacksize = 6000
start = true
uses = []
task-slots = [
"jefe",
"dump_agent",
"net",
"update_server",
"sys",
Expand Down Expand Up @@ -318,7 +319,7 @@ features = ["net", "vlan"]

[tasks.idle]
name = "task-idle"
priority = 6
priority = 7
max-sizes = {flash = 128, ram = 256}
stacksize = 256
start = true
Expand Down
1 change: 1 addition & 0 deletions app/sidecar/base.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,6 +113,7 @@ start = true
uses = []
task-slots = [
"auxflash",
"dump_agent",
"ignition",
"jefe",
"monorail",
Expand Down
14 changes: 14 additions & 0 deletions idl/dump-agent.idol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,20 @@ Interface(
err: CLike("DumpAgentError"),
),
),
"read_dump_into": (
doc: "Fetch bytes from the dump at the specified offset from the specified area",
args: {
"index": "u8",
"offset": "u32",
},
leases: {
"out": (type: "[u8]", write: true),
},
reply: Result(
ok: "usize",
err: CLike("DumpAgentError"),
),
),
"get_dump_area": (
doc: "Return information associated with the specified dump area.",
args: {
Expand Down
2 changes: 2 additions & 0 deletions task/control-plane-agent/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ cfg-if.workspace = true
enum-map.workspace = true
gateway-messages.workspace = true
heapless.workspace = true
humpty.workspace = true
idol-runtime.workspace = true
num-traits.workspace = true
serde.workspace = true
Expand All @@ -34,6 +35,7 @@ drv-transceivers-api = { path = "../../drv/transceivers-api", optional = true }
drv-update-api = { path = "../../drv/update-api" }
drv-user-leds-api = { path = "../../drv/user-leds-api", optional = true }
drv-rng-api = { path = "../../drv/rng-api", optional = true }
dump-agent-api = { path = "../dump-agent-api" }
task-vpd-api = { path = "../../task/vpd-api", optional = true }
host-sp-messages = { path = "../../lib/host-sp-messages" }
lpc55-rom-data = { path = "../../lib/lpc55-rom-data" }
Expand Down
Loading
Loading