Rename task's name member to bin-crate #2195
Open
+374
−371
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change renames the `name` member of the `Task` struct to `bin-crate` in order to make it more clear to new users that the value refers to an actual crate, and is not the name of the task (which is the key in the map). Fixes oxidecomputer#196
thenewwazoo
added a commit
to thenewwazoo/humility
that referenced
this pull request
Aug 14, 2025
Per [the corresponding hubris PR], update all the test data to similarly replace `task.$name.name` with `task.$name.bin-crate`. [the corresponding hubris PR]: oxidecomputer/hubris#2195
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change renames the
namemember of theTaskstruct tobin-cratein order to make it more clear to new users that the value refers to an actual crate, and is not the name of the task (which is the key in the map).(This is admittedly a very silly PR fixing an issue dating back to 2021 but it did actually trip me up.)
Fixes #196