Add LastPostCode component details to SP5 host CPU
#2251
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2244
We would like to be able to read the
LAST_POST_CODEregister from the FPGA. This PR adds it as aComponentDetailto theSP5_HOST_CPUcomponent.The MGS side is oxidecomputer/management-gateway-service#451, so this is marked as a draft (but can still be reviewed).
There are two interesting changes:
Inventory::num_component_detailsnow returns 1 for theSP5_HOST_CPUcomponentInventory::component_detailsnow accepts a closure to handle any components inOUR_DEVICESThe rest of the PR is mostly plumbing, e.g. adding modules to the generated FMC code (because otherwise we have name collisions between
espiandsequencerregisters).I tested this on the bench with a Grapefruit, and it "works":
I've also tested the
Sequencer.last_post_codefunction on a Cosmo throughhumility hiffy. I would like to do an end-to-end test, but Cosmos with network connectivity are in high demand (see https://github.com/oxidecomputer/meta/issues/761)