[1/2] [xtask] migrate to clap #37
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Created using spr 1.3.6-beta.1
Nieuwejaar
reviewed
Oct 1, 2025
| Omicron, // package to be included in an omicron zone | ||
| Global, // package to run standalone in the global zone | ||
| /// .deb or .p5p, depending on the platform | ||
| #[value(alias = "n")] |
There was a problem hiding this comment.
The ValueEnum means we get the --format omicron for free without the FromStr implementation, right? The buildomat jobs are still using the long form of the option and passing, so I assume this is fine.
There was a problem hiding this comment.
Yeah, both the short and long forms will work, so there aren't any behavior changes compared to today.
Nieuwejaar
approved these changes
Oct 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm going to add an xtask to manage OpenAPI documents soon, and the template I currently have works with clap.
Also replace the manual
FromStrwithValueEnum.