Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Static route key retained despite deleting all paths #369

Closed
taspelund opened this issue Sep 17, 2024 · 0 comments · Fixed by #385
Closed

Static route key retained despite deleting all paths #369

taspelund opened this issue Sep 17, 2024 · 0 comments · Fixed by #385
Labels
Bug static Static Routing

Comments

@taspelund
Copy link
Contributor

Building from main, I see this when manually testing adding/removing static routes:

➜  maghemite git:(f5dbb6a) ./target/debug/mgadm static add-v4-route 1.1.1.1/32 100.64.0.0
➜  maghemite git:(f5dbb6a) ./target/debug/mgadm static add-v4-route 1.1.1.1/32 100.64.0.1
➜  maghemite git:(f5dbb6a) ./target/debug/mgadm static get-v4-routes
{
    "1.1.1.1/32": [
        Path {
            bgp: None,
            local_pref: None,
            nexthop: 100.64.0.0,
            shutdown: false,
            vlan_id: None,
        },
        Path {
            bgp: None,
            local_pref: None,
            nexthop: 100.64.0.1,
            shutdown: false,
            vlan_id: None,
        },
    ],
}
➜  maghemite git:(f5dbb6a) ./target/debug/mgadm static remove-v4-routes 1.1.1.1/32 100.64.0.0
➜  maghemite git:(f5dbb6a) ./target/debug/mgadm static get-v4-routes
{
    "1.1.1.1/32": [
        Path {
            bgp: None,
            local_pref: None,
            nexthop: 100.64.0.1,
            shutdown: false,
            vlan_id: None,
        },
    ],
}
➜  maghemite git:(f5dbb6a) ./target/debug/mgadm static remove-v4-routes 1.1.1.1/32 100.64.0.1
➜  maghemite git:(f5dbb6a) ./target/debug/mgadm static get-v4-routes
{
    "1.1.1.1/32": [],
}

I don't think we should be retaining 1.1.1.1/32 after deletion of the last path.

@taspelund taspelund added Bug static Static Routing labels Sep 17, 2024
taspelund added a commit that referenced this issue Oct 3, 2024
Fixes: #369

Signed-off-by: Trey Aspelund <trey@oxidecomputer.com>
taspelund added a commit that referenced this issue Oct 20, 2024
Fixes: #369

Signed-off-by: Trey Aspelund <trey@oxidecomputer.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug static Static Routing
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant