set reqwest.default-features = false; update FALCON
#437
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
rcgoodfellow
force-pushed
the
iliana/omicron7624
branch
from
9d9a799 to
8322018
Compare
rcgoodfellow
approved these changes
Mar 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is part of oxidecomputer/omicron#7624.
reqwest has the unfortunate behavior of having an on-by-default feature flag that includes native-tls. Removing the default feature flags allows downstream crates to decide on those features on their own.
Other default feature flags disabled here are
encoding(not relevant for JSON which is always UTF-8),http2, andmacos-system-configuration(which automatically configures proxy settings on macOS).FALCON is bumped to pick up oxidecomputer/falcon#105, part of this same set of changes.