Initial IPv6 Support

.github/buildomat/jobs/test-bfd.sh

@@ -6,6 +6,7 @@
 #: rust_toolchain = "stable"
 #: output_rules = [
 #:   "/work/*.log",
+#:   "/tmp/*.db",
 #: ]
 #:
 

.github/buildomat/jobs/test-bgp.sh

@@ -14,11 +14,11 @@ set -e
 
 source .github/buildomat/test-common.sh
 pushd bgp
-cargo nextest run
+pfexec cargo nextest run
 cp *.log /work/
 popd
 
 pushd mgd
-cargo nextest run
+pfexec cargo nextest run
 cp *.log /work/
 popd

.github/buildomat/jobs/test-interop.sh

@@ -60,8 +60,8 @@ net_info() {
 		MGD_IP=$(pfexec ./interop exec mgd "ipadm show-addr $MGD_IF/v4 -p -o addr | cut -d / -f 1")
 	fi
 	ssh root@"$MGD_IP" "/opt/cargo-bay/mgadm bgp status neighbors 65100"
-	ssh root@"$MGD_IP" "/opt/cargo-bay/mgadm bgp status imported 65100"
-	ssh root@"$MGD_IP" "/opt/cargo-bay/mgadm bgp status selected 65100"
+	ssh root@"$MGD_IP" "/opt/cargo-bay/mgadm rib status imported"
+	ssh root@"$MGD_IP" "/opt/cargo-bay/mgadm rib status selected"
 	ssh root@"$MGD_IP" "/opt/cargo-bay/mgadm bgp status exported 65100"
 }
 

.github/buildomat/jobs/test-mgadm.sh

@@ -0,0 +1,32 @@
+#!/bin/bash
+#:
+#: name = "test-mgadm"
+#: variety = "basic"
+#: target = "helios-2.0"
+#: rust_toolchain = "stable"
+#: output_rules = [
+#:   "/work/*.log",
+#: ]
+#: access_repos = [
+#:   "oxidecomputer/dendrite",
+#: ]
+#:
+
+set -x
+set -e
+
+# NOTE: This version should be in sync with the recommended version in
+# .config/nextest.toml. (Maybe build an automated way to pull the recommended
+# version in the future.)
+NEXTEST_VERSION='0.9.97'
+PLATFORM='illumos'
+
+cargo --version
+rustc --version
+cargo install cargo-nextest --version "$NEXTEST_VERSION"
+
+source .github/buildomat/test-common.sh
+
+pushd mgadm
+
+cargo nextest run

.github/buildomat/jobs/test-proptest.sh

@@ -0,0 +1,50 @@
+#!/bin/bash
+#:
+#: name = "test-proptest"
+#: variety = "basic"
+#: target = "helios-2.0"
+#: rust_toolchain = "stable"
+#: output_rules = [
+#:   "/work/*.log",
+#:   "/work/proptest-regressions/*",
+#:   "/tmp/*.db",
+#: ]
+#: access_repos = [
+#:   "oxidecomputer/dendrite",
+#: ]
+#:
+
+set -x
+set -e
+
+# NOTE: This version should be in sync with the recommended version in
+# .config/nextest.toml. (Maybe build an automated way to pull the recommended
+# version in the future.)
+NEXTEST_VERSION='0.9.97'
+PLATFORM='illumos'
+
+cargo --version
+rustc --version
+cargo install cargo-nextest --version "$NEXTEST_VERSION"
+
+source .github/buildomat/test-common.sh
+
+# Run property-based tests with high intensity (default is 256)
+
+# RDB proptest suite
+pushd rdb
+PROPTEST_CASES=1000000 cargo nextest run --lib proptest
+cp *.log /work/ 2>/dev/null || true
+if [ -d proptest-regressions ]; then
+    cp -r proptest-regressions /work/rdb-proptest-regressions
+fi
+popd
+
+# BGP proptest suite
+pushd bgp
+PROPTEST_CASES=1000000 cargo nextest run --lib proptest
+cp *.log /work/ 2>/dev/null || true
+if [ -d proptest-regressions ]; then
+    cp -r proptest-regressions /work/bgp-proptest-regressions
+fi
+popd

.github/buildomat/jobs/test-rdb.sh

@@ -6,6 +6,7 @@
 #: rust_toolchain = "stable"
 #: output_rules = [
 #:   "/work/*.log",
+#:   "/tmp/*.db",
 #: ]
 #:
 

.github/buildomat/test-common.sh

@@ -17,4 +17,4 @@ set -o errexit
 
 cargo --version
 rustc --version
-curl -sSfL --retry 10 https://get.nexte.st/"$NEXTEST_VERSION"/"$PLATFORM" | gunzip | tar -xvf - -C ~/.cargo/bin
+cargo install cargo-nextest --version "$NEXTEST_VERSION"

Cargo.toml

@@ -78,7 +78,6 @@ reqwest = { version = "0.12", default-features = false, features = ["json", "str
 clap = { version = "4.5.47", features = ["derive", "unstable-styles", "env"] }
 tabwriter = { version = "1", features = ["ansi_formatting"] }
 colored = "3.0"
-ctrlc = { version = "3.4.7", features = ["termination"] }
 ztest = { git = "https://github.com/oxidecomputer/falcon", branch = "main" }
 anstyle = "1.0.11"
 nom = "7.1"
@@ -108,6 +107,7 @@ libc = "0.2"
 itertools = "0.14"
 rhai = { version = "1", features = ["metadata", "sync"] }
 semver = "1.0"
+proptest = "1.4"
 ddm-api = { path = "ddm-api" }
 ddm-types = { path = "ddm-types" }
 

bfd/src/lib.rs

@@ -15,10 +15,17 @@ use std::sync::atomic::AtomicU64;
 use std::time::Duration;
 
 pub mod bidi;
+pub mod log;
 pub mod packet;
 mod sm;
 mod util;
 
+pub const COMPONENT_BFD: &str = "bfd";
+pub const MOD_DAEMON: &str = "daemon";
+pub const MOD_SM: &str = "state_machine";
+
+pub const UNIT_PEER: &str = "peer";
+
 /// A `Daemon` is a collection of BFD sessions.
 pub struct Daemon {
     /// Sessions keyed by peer IP address.
@@ -49,7 +56,10 @@ impl Daemon {
     ) {
         if self.sessions.contains_key(&peer) {
             warn!(self.log, "attempt to add peer that already exists";
-                "peer" => format!("{:#?}", peer)
+                "component" => COMPONENT_BFD,
+                "module" => MOD_DAEMON,
+                "unit" => UNIT_PEER,
+                "peer" => format!("{peer}")
             );
             return;
         }
@@ -310,9 +320,10 @@ mod test {
 
     #[test]
     fn test_new_daemon() -> anyhow::Result<()> {
-        let db = rdb::Db::new("/tmp/bfd_new_daemon.db", test_logger()).unwrap();
+        let log = test_logger();
+        let db = rdb::test::get_test_db("bfd_new_daemon", log.clone()).unwrap();
 
-        let mut daemon = Daemon::new(test_logger());
+        let mut daemon = Daemon::new(log);
         assert_eq!(daemon.sessions.len(), 0);
 
         let (a, _b) = bidi::channel();
@@ -323,7 +334,7 @@ mod test {
             3,
             SessionMode::MultiHop,
             a,
-            db,
+            db.db().clone(),
         );
         assert_eq!(daemon.peer_state(p1_addr), Some(BfdPeerState::Down));
 
@@ -332,7 +343,9 @@ mod test {
 
     #[test]
     fn test_protocol_basics() -> anyhow::Result<()> {
-        let db = rdb::Db::new("/tmp/bfd_new_daemon.db", test_logger()).unwrap();
+        let log = test_logger();
+        let db =
+            rdb::test::get_test_db("bfd_protocol_basics", log.clone()).unwrap();
 
         let mut net = Network::default();
 
@@ -347,7 +360,7 @@ mod test {
             3,
             SessionMode::MultiHop,
             a,
-            db.clone(),
+            db.db().clone(),
         );
         net.register(addr2, b);
 
@@ -359,7 +372,7 @@ mod test {
             3,
             SessionMode::MultiHop,
             a,
-            db,
+            db.db().clone(),
         );
         net.register(addr1, b);