Skip to content

Commit

Permalink
remove outdated reference in comment
Browse files Browse the repository at this point in the history
  • Loading branch information
hawkw committed Jan 30, 2025
1 parent 3dfa94f commit 0a7601b
Showing 1 changed file with 3 additions and 6 deletions.
9 changes: 3 additions & 6 deletions nexus/src/app/sagas/instance_create.rs
Original file line number Diff line number Diff line change
Expand Up @@ -983,12 +983,9 @@ async fn sic_delete_instance_record(
.instance_id(instance_id.into_untyped_uuid())
.fetch()
.await;

// Although, as mentioned in the comment above, we should not be doing the
// lookup by name here, we do want this operation to be idempotent.
//
// As such, if the instance has already been deleted, we should return with
// a no-op.
// This action must be idempotent, so that an unwinding saga doesn't get
// stuck if it executes twice. Therefore, if the instance has already been
// deleted, we should return with a no-op, rather than an error.
let authz_instance = match result {
Ok((.., authz_instance, _)) => authz_instance,
Err(err) => match err {
Expand Down

0 comments on commit 0a7601b

Please sign in to comment.