Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[API] Bounds-check that memory for instance is above a minimum, meets a granularity #1030

Closed
smklein opened this issue May 6, 2022 · 2 comments
Closed

[API] Bounds-check that memory for instance is above a minimum, meets a granularity #1030

smklein opened this issue May 6, 2022 · 2 comments
Labels
api Related to the API. good first issue Issues that are good for learning the codebase nexus Related to nexus

Comments

@smklein
Copy link
Collaborator

smklein commented May 6, 2022

... effectively #1029 , but for instance memory size.
@smklein smklein added api Related to the API. nexus Related to nexus good first issue Issues that are good for learning the codebase labels May 6, 2022
ryaeng added a commit to ryaeng/omicron that referenced this issue Jun 3, 2022
@ryaeng
[API] Bounds-check that memory for instance is above a minimum, meets a
adf2bcc 
granularity (oxidecomputer#1030)

- Require the user to select a memory size of at least one gibibyte
    when creating a new instance.
- Create new test to match this requirement.
- Update tests that created instances under one gibibyte.
@ryaeng ryaeng mentioned this issue Jun 6, 2022
Closed
@smklein smklein mentioned this issue Jun 7, 2022
Merged
@ryaeng
Copy link
Contributor

ryaeng commented Jun 9, 2022

Done with this one also

smklein pushed a commit that referenced this issue Jun 13, 2022
@ryaeng
[API] Bounds-check that memory for instance is above a minimum, meets…
bf4a057 
… a granularity (#1030) (#1157)

- Require the user to select a memory size of at least one gibibyte
    when creating a new instance.
- Create new test to match this requirement.
- Update tests that created instances under one gibibyte.
@bnaecker
Copy link
Collaborator

Closed by #1157

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
api Related to the API. good first issue Issues that are good for learning the codebase nexus Related to nexus
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@smklein @bnaecker @ryaeng