Skip to content

Deleting an instance should detach disks #1031

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
plotnick opened this issue May 6, 2022 · 0 comments · Fixed by #1068
Closed

Deleting an instance should detach disks #1031

plotnick opened this issue May 6, 2022 · 0 comments · Fixed by #1068
Assignees
@jmpesp
Labels
nexus Related to nexus

Comments

@plotnick
Copy link
Contributor

plotnick commented May 6, 2022

When we delete an instance, we should look for disks that are currently attached to it and detach them. Otherwise we end up with a "wedged" disk.
@plotnick plotnick added the nexus Related to nexus label May 6, 2022
jmpesp added a commit to jmpesp/omicron that referenced this issue May 13, 2022
@jmpesp
detach disks on instance delete
cece857 
lookup all disks attached to an instance during instance delete, and
detach them before the instance is been deleted.

fixes oxidecomputer#1031
@jmpesp jmpesp mentioned this issue May 13, 2022
Merged
@jmpesp jmpesp self-assigned this May 13, 2022
jmpesp added a commit that referenced this issue May 16, 2022
@jmpesp
detach disks on instance delete (#1068)
e2c5d84 
lookup all disks attached to an instance during instance delete, and
detach them before the instance is been deleted.

fixes #1031
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jmpesp jmpesp

Labels
nexus Related to nexus
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

detach disks on instance delete jmpesp/omicron
2 participants
@plotnick @jmpesp