Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

External address queries should be idempotent. #1316

Closed
bnaecker opened this issue Jun 30, 2022 · 2 comments
Closed

External address queries should be idempotent. #1316

bnaecker opened this issue Jun 30, 2022 · 2 comments
Labels
database Related to database access nexus Related to nexus

Comments

@bnaecker
Copy link
Collaborator

External addresses are created during sagas. Multiple addresses are deallocated at once when an instance is destroyed. Neither of these is correctly idempotent. See the linked comment for more details, and suggested solutions. Will fill this out more as needed.

Originally posted by @bnaecker in #1298 (comment)
@bnaecker bnaecker added database Related to database access nexus Related to nexus labels Jun 30, 2022
@bnaecker
Copy link
Collaborator Author

Added first part of this in #1458, which creates UUIDs as a separate saga action. Actual idempotency requires rewriting the allocation query.

@bnaecker bnaecker mentioned this issue Jul 25, 2022
Merged
@bnaecker
Copy link
Collaborator Author

Closed by #1493

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
database Related to database access nexus Related to nexus
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@bnaecker