Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds external IPs for instance source NAT #1298

Merged
merged 2 commits into from
Jun 30, 2022
Merged

Adds external IPs for instance source NAT #1298

merged 2 commits into from
Jun 30, 2022

Conversation

bnaecker
Copy link
Collaborator

  • Adds the instance_external_ip table for tracking external IP
    addresses and port ranges for instance source NAT, allocated out of an
    IP pool / range.
  • Adds child-generation counter and tracking to the ip_pool_range
    table, and checks for allocated addresses when deleting a range.
  • Adds query to insert next available address from any range, updating
    the parent rcgen. Adds tests for query behavior, including testing
    exhaustion.
  • Add test helper to create an IP pool and range, since all
    instance-creation tests now need to have a pool available.
  • Forwards external IP configuration to sled agent and passes to OPTE.

@bnaecker
Adds external IPs for instance source NAT
9a56ff1 
- Adds the `instance_external_ip` table for tracking external IP
  addresses and port ranges for instance source NAT, allocated out of an
  IP pool / range.
- Adds child-generation counter and tracking to the `ip_pool_range`
  table, and checks for allocated addresses when deleting a range.
- Adds query to insert next available address from any range, updating
  the parent rcgen. Adds tests for query behavior, including testing
  exhaustion.
- Add test helper to create an IP pool and range, since all
  instance-creation tests now need to have a pool available.
- Forwards external IP configuration to sled agent and passes to OPTE.
@bnaecker bnaecker mentioned this pull request Jun 29, 2022
Open
@smklein smklein self-assigned this Jun 30, 2022
smklein
smklein approved these changes Jun 30, 2022
View reviewed changes
nexus/src/app/sagas/instance_create.rs Show resolved Hide resolved
sled-agent/src/params.rs Show resolved Hide resolved
nexus/tests/integration_tests/ip_pools.rs Show resolved Hide resolved
common/src/sql/dbinit.sql Show resolved Hide resolved
nexus/src/db/queries/external_ip.rs Outdated Show resolved Hide resolved
@smklein smklein removed their assignment Jun 30, 2022
@bnaecker bnaecker mentioned this pull request Jun 30, 2022
Closed
@bnaecker
Review feedback
2c13ebd 
- Deallocation of external IPs is idempotent
- Cleanup and comments
@bnaecker bnaecker enabled auto-merge (squash) June 30, 2022 04:30
@bnaecker bnaecker merged commit e5704d7 into main Jun 30, 2022
@bnaecker bnaecker deleted the allocate-instance-nat-ips branch June 30, 2022 05:37
This was referenced Jun 30, 2022
Closed
Closed
@bnaecker bnaecker mentioned this pull request Jul 20, 2022
Open
leftwo pushed a commit that referenced this pull request Jun 26, 2024
Update crucible, add DTrace crucible to host image
3a09cb9 
Added a new package, crucible-dtrace that pulls from buildomat a package
that contains a set of DTrace scripts.  These scripts are extracted into
the global zone at /opt/oxide/crucible_dtrace/

Update Crucible to latest includes these updates:
Clean up dependency checking, fixing space leak (#1372)
Make a DTrace package (#1367)
Use a single context in all messages (#1363)
Remove `DownstairsWork`, because it's redundant (#1371)
Remove `WorkState`, because it's implicit (#1370)
Do work immediately upon receipt of a job, if possible (#1366)
Move 'do work for one job' into a helper function (#1365)
Remove `DownstairsWork` from map when handling it (#1361)
Using `block_in_place` for IO operations (#1357)
update omicron deps; use re-exported dropshot types in oximeter-producer configuration (#1369)
Parameterize more tests (#1364)
Misc cleanup, remove sqlite references. (#1360)
Fix `Extent::close` docstring (#1359)
Make many `Region` functions synchronous (#1356)
Remove `Workstate::Done` (unused) (#1355)
Return a sorted `VecDeque` directly (#1354)
Combine `proc_frame` and `do_work_for` (#1351)
Move `do_work_for` and `do_work` into `ActiveConnection` (#1350)
Support arbitrary Volumes during replace compare (#1349)
Remove the SQLite backend (#1352)
Add a custom timeout for buildomat tests (#1344)
Move `proc_frame` into `ActiveConnection` (#1348)
Remove `UpstairsConnection` from `DownstairsWork` (#1341)
Move Work into ConnectionState (#1340)
Make `ConnectionState` an enum type (#1339)
Parameterize `test_repair.sh` directories (#1345)
Remove `Arc<Mutex<Downstairs>>` (#1338)
Send message to Downstairs directly (#1336)
Consolidate `on_disconnected` and `remove_connection` (#1333)
Move disconnect logic to the Downstairs (#1332)
Remove invalid DTrace probes. (#1335)
Fix outdated comments (#1331)
Use message passing when a new connection starts (#1330)
Move cancellation into Downstairs, using a token to kill IO tasks (#1329)
Make the Downstairs own per-connection state (#1328)
Move remaining local state into a `struct ConnectionState` (#1327)
Consolidate negotiation + IO operations into one loop (#1322)
Allow replacement of a target in a read_only_parent (#1281)
Do all IO through IO tasks (#1321)
Make `reqwest_client` only present if it's used (#1326)
Move negotiation into Downstairs as well (#1320)
Update Rust crate clap to v4.5.4 (#1301)
Reuse a reqwest client when creating Nexus clients (#1317)
Reuse a reqwest client when creating repair client (#1324)
Add % to keep buildomat happy (#1323)
Downstairs task cleanup (#1313)
Update crutest replace test, and mismatch printing. (#1314)
Added more DTrace scripts. (#1309)
Update Rust crate async-trait to 0.1.80 (#1298)
@leftwo leftwo mentioned this pull request Jun 26, 2024
Merged
leftwo added a commit that referenced this pull request Jun 26, 2024
@leftwo
Update crucible, add DTrace crucible to host image (#5954)
6e29409 
Update Crucible and Propolis to the latest

Added a new package, crucible-dtrace that pulls from buildomat a package
that contains a set of DTrace scripts. These scripts are extracted into the 
global zone at /opt/oxide/crucible_dtrace/

Crucible latest includes these updates:
Clean up dependency checking, fixing space leak (#1372) Make a DTrace
package (#1367)
Use a single context in all messages (#1363)
Remove `DownstairsWork`, because it's redundant (#1371) Remove
`WorkState`, because it's implicit (#1370)
Do work immediately upon receipt of a job, if possible (#1366) Move 'do
work for one job' into a helper function (#1365) Remove `DownstairsWork`
from map when handling it (#1361) Using `block_in_place` for IO
operations (#1357)
update omicron deps; use re-exported dropshot types in oximeter-producer
configuration (#1369) Parameterize more tests (#1364)
Misc cleanup, remove sqlite references. (#1360)
Fix `Extent::close` docstring (#1359)
Make many `Region` functions synchronous (#1356)
Remove `Workstate::Done` (unused) (#1355)
Return a sorted `VecDeque` directly (#1354)
Combine `proc_frame` and `do_work_for` (#1351)
Move `do_work_for` and `do_work` into `ActiveConnection` (#1350) Support
arbitrary Volumes during replace compare (#1349) Remove the SQLite
backend (#1352)
Add a custom timeout for buildomat tests (#1344)
Move `proc_frame` into `ActiveConnection` (#1348)
Remove `UpstairsConnection` from `DownstairsWork` (#1341) Move Work into
ConnectionState (#1340)
Make `ConnectionState` an enum type (#1339)
Parameterize `test_repair.sh` directories (#1345)
Remove `Arc<Mutex<Downstairs>>` (#1338)
Send message to Downstairs directly (#1336)
Consolidate `on_disconnected` and `remove_connection` (#1333) Move
disconnect logic to the Downstairs (#1332)
Remove invalid DTrace probes. (#1335)
Fix outdated comments (#1331)
Use message passing when a new connection starts (#1330) Move
cancellation into Downstairs, using a token to kill IO tasks (#1329)
Make the Downstairs own per-connection state (#1328) Move remaining
local state into a `struct ConnectionState` (#1327) Consolidate
negotiation + IO operations into one loop (#1322) Allow replacement of a
target in a read_only_parent (#1281) Do all IO through IO tasks (#1321)
Make `reqwest_client` only present if it's used (#1326) Move negotiation
into Downstairs as well (#1320)
Update Rust crate clap to v4.5.4 (#1301)
Reuse a reqwest client when creating Nexus clients (#1317) Reuse a
reqwest client when creating repair client (#1324) Add % to keep
buildomat happy (#1323)
Downstairs task cleanup (#1313)
Update crutest replace test, and mismatch printing. (#1314) Added more
DTrace scripts. (#1309)
Update Rust crate async-trait to 0.1.80 (#1298)

Propolis just has this one update:
Allow boot order config in propolis-standalone
---------

Co-authored-by: Alan Hanson <alan@oxide.computer>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smklein smklein smklein approved these changes

@davepacheco davepacheco Awaiting requested review from davepacheco

@jmpesp jmpesp Awaiting requested review from jmpesp

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bnaecker @smklein