update propolis and crucible deps #1074
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmpesp
requested changes
May 16, 2022
| @@ -84,7 +84,7 @@ zone = true | |||
| # 3. Use type = "manual" instead of the "prebuilt" | |||
| type = "prebuilt" | |||
| repo = "crucible" | |||
| commit = "d412b2be7ef8c0658bf5603f7fd746f6972e4666" | |||
| commit = "8ea317a9dfee65d7c018a1fda89fdec63a560ef3" | |||
| # The SHA256 digest is automatically posted to: | |||
| # https://buildomat.eng.oxide.computer/public/file/oxidecomputer/crucible/image/<commit>/crucible.sha256.txt | |||
| sha256 = "f85bb22797bab58d128c8dd168a2e6ba57feee284bdc9d0adf282197cb45cccb" | |||
There was a problem hiding this comment.
it's surprising to me that this didn't change, given the commit rev did...?
There was a problem hiding this comment.
$ curl -sq https://buildomat.eng.oxide.computer/public/file/oxidecomputer/crucible/image/d412b2be7ef8c0658bf5603f7fd746f6972e4666/crucible.sha256.txt
f85bb22797bab58d128c8dd168a2e6ba57feee284bdc9d0adf282197cb45cccb
$ curl -sq https://buildomat.eng.oxide.computer/public/file/oxidecomputer/crucible/image/8ea317a9dfee65d7c018a1fda89fdec63a560ef3/crucible.sha256.txt
f85bb22797bab58d128c8dd168a2e6ba57feee284bdc9d0adf282197cb45cccb
seems legit
There was a problem hiding this comment.
very odd:
$ curl https://buildomat.eng.oxide.computer/public/file/oxidecomputer/crucible/image/d412b2be7ef8c0658bf5603f7fd746f6972e4666/crucible.sha256.txt
f85bb22797bab58d128c8dd168a2e6ba57feee284bdc9d0adf282197cb45cccb
$ curl https://buildomat.eng.oxide.computer/public/file/oxidecomputer/crucible/image/8ea317a9dfee65d7c018a1fda89fdec63a560ef3/crucible.sha256.txt
f85bb22797bab58d128c8dd168a2e6ba57feee284bdc9d0adf282197cb45cccbThere was a problem hiding this comment.
@jclulow do you have any insights as to how this might happen?
There was a problem hiding this comment.
propolis does not seem to have this problem:
$ for commit in $(git log | grep commit | head -n10 | cut -d' ' -f2); do echo "${commit} $(curl -sq https://buildomat.eng.oxide.computer/public/file/oxidecomputer/propolis/image/${commit}/propolis-server.tar.gz | sha256sum)"; done;
36d5ba53a421e0bf251abd1e3114011f5a7cd2c3 30a4606c0ca6e9b9a9c11a70489ce6dabf62ef3b884912b9cde3f6d0efb06def -
2129d16b1a677fd57ac382a905f1304195589a90 02127e631d77f5114ed96881007c0e13a5a932432b92afd94c871e685271e03e -
4c9fbd1b3cd75896308264a60e6df3a011797807 9cd05d81571a0ab8604658b4c7a8e7a065a2cf3a9c4f95bddee529e08ca8991e -
de0ac67e5e1e19a905e9a6e02da342dbbabf2d09 65ee923b9b774089a346cd32f5b1c9fbe140b49d0d2da6febd7e238d9c8dccd7 -
47ef18a5b0eb7a208ae43e669cf0a93d65576114 058e809987011743008382332f5755498ae81b18019a608b4c69acc56ad51721 -
eaec980e060b368c4ca39aaaaf7757cecdb43ecc 0522bf1644867e53e8931851e55001fb7edf81897803a96ba8071d5a73d5f179 -
ec4f3a41a638ea6c3316a86f30f1895f4877f2ef fd3ac7cfa6659033051bb29ecc297240c519c5db339045f17ecccf594a266811 -
514fa1fc7740209fcb4b38397b9fe7e6c2df30cb 2de46d18505f022d38e12b65a8d0b985bd705c9c8f532d10b79ec909d8b48dde -
bb18d9b9e2c153d016204b1a41535e603d36bad6 2582d18c12c81ee60f632a36cc6c32c6d863db9253f7710f7c21c16c45e1072f -
fc09089e2d8a238637449a59752bf134f52631bb b284af2c879d58dbc549eed3690dcca957be41856b94b50090cda9e4ef93fcaa -
There was a problem hiding this comment.
The SHA256 references the generated zone image, not the entire source tree at a particular commit.
If changes were made to the repo that did not modify the downstairs zone image, I would expect it to stay the same.
There was a problem hiding this comment.
That seems right. This last commit that @ahl added didn't change anything that's packaged into the zone tarball, but some of those previous commits do change things like the agent or downstairs binaries yet result in the same SHA. I'd expect that to change the digest of the zone image, but I could be missing something.
There was a problem hiding this comment.
I didn't realize that build were purely deterministic.
There was a problem hiding this comment.
That is indeed quite impressive
bnaecker
approved these changes
May 16, 2022
leftwo
pushed a commit
that referenced
this pull request
Jan 10, 2024
Propolis changes since the last update: Gripe when using non-raw block device Update zerocopy dependency nvme: Wire up GetFeatures command Make Viona more robust in the face of errors bump softnpu (#577) Modernize 16550 UART Crucible changes since the last update: Don't check ROP if the scrub is done (#1093) Allow crutest cli to be quiet on generic test (#1070) Offload write encryption (#1066) Simplify handling of BlockReq at program exit (#1085) Update Rust crate byte-unit to v5 (#1054) Remove unused fields in match statements, downstairs edition (#1084) Remove unused fields in match statements and consolidate (#1083) Add logger to Guest (#1082) Drive hash / decrypt tests from Upstairs::apply Wait to reconnect if auto_promote is false Change guest work id from u64 -> GuestWorkId remove BlockOp::Commit (#1072) Various clippy fixes (#1071) Don't panic if tasks are destroyed out of order Update Rust crate reedline to 0.27.1 (#1074) Update Rust crate async-trait to 0.1.75 (#1073) Buffer should destructure to Vec when single-referenced Don't fail to make unencrypted regions (#1067) Fix shadowing in downstairs (#1063) Single-task refactoring (#1058) Update Rust crate tokio to 1.35 (#1052) Update Rust crate openapiv3 to 2.0.0 (#1050) Update Rust crate libc to 0.2.151 (#1049) Update Rust crate rusqlite to 0.30 (#1035)
leftwo
added a commit
that referenced
this pull request
Jan 11, 2024
Propolis changes since the last update: Gripe when using non-raw block device Update zerocopy dependency nvme: Wire up GetFeatures command Make Viona more robust in the face of errors bump softnpu (#577) Modernize 16550 UART Crucible changes since the last update: Don't check ROP if the scrub is done (#1093) Allow crutest cli to be quiet on generic test (#1070) Offload write encryption (#1066) Simplify handling of BlockReq at program exit (#1085) Update Rust crate byte-unit to v5 (#1054) Remove unused fields in match statements, downstairs edition (#1084) Remove unused fields in match statements and consolidate (#1083) Add logger to Guest (#1082) Drive hash / decrypt tests from Upstairs::apply Wait to reconnect if auto_promote is false Change guest work id from u64 -> GuestWorkId remove BlockOp::Commit (#1072) Various clippy fixes (#1071) Don't panic if tasks are destroyed out of order Update Rust crate reedline to 0.27.1 (#1074) Update Rust crate async-trait to 0.1.75 (#1073) Buffer should destructure to Vec when single-referenced Don't fail to make unencrypted regions (#1067) Fix shadowing in downstairs (#1063) Single-task refactoring (#1058) Update Rust crate tokio to 1.35 (#1052) Update Rust crate openapiv3 to 2.0.0 (#1050) Update Rust crate libc to 0.2.151 (#1049) Update Rust crate rusqlite to 0.30 (#1035) --------- Co-authored-by: Alan Hanson <alan@oxide.computer>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
lockstep told me there was nothing else to be done