Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clean up Polar file: non-functional changes #1112

Merged
merged 7 commits into from
May 25, 2022
Merged

clean up Polar file: non-functional changes #1112

merged 7 commits into from
May 25, 2022

Conversation

davepacheco
Copy link
Collaborator

@davepacheco davepacheco commented May 24, 2022

Depends on #1110.

This change improves the documentation and structure of our Oso Polar policy file. This contains no functional changes -- it only changes comments and reorders a few things. I'll make a separate PR for some cleanup that technically changes the contents. I separated these in hopes that both PRs will be much easier to review than one that has both functional changes and a bunch of reordering, etc.

Heads up @jmpesp -- this will affect #814 but I hope it'll make things clearer and won't be too hard to rebase on top of. Let me know if it'll be too disruptive.

@davepacheco davepacheco requested a review from plotnick May 24, 2022 22:28
@davepacheco davepacheco marked this pull request as ready for review May 24, 2022 22:31
@davepacheco davepacheco changed the title clean up Polar file (non-functional changes) clean up Polar file: non-functional changes May 24, 2022
Copy link
Contributor

@plotnick plotnick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unambiguously clearer - thanks!

nexus/src/authz/omicron.polar Outdated Show resolved Hide resolved
Base automatically changed from authz-role-test-fixes to main May 24, 2022 23:44
@davepacheco davepacheco enabled auto-merge (squash) May 25, 2022 00:03
@davepacheco davepacheco mentioned this pull request May 25, 2022
69 tasks
@davepacheco davepacheco merged commit cb75b16 into main May 25, 2022
@davepacheco davepacheco deleted the polar-cleanup branch May 25, 2022 00:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants