Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Instance to VmInstance #1232

Closed
wants to merge 10 commits into from
Closed

Conversation

ryaeng
Copy link
Contributor

@ryaeng ryaeng commented Jun 20, 2022

Changing the ambiguous type of Instance to VmInstance at the web, app, and db layers.

See #1192 for the request.

@ryaeng
Copy link
Contributor Author

ryaeng commented Jun 24, 2022

@smklein @david-crespo Could either of you review my pull request?

@david-crespo
Copy link
Contributor

Yes, but we're working toward an internal deadline and will likely not get to this until next week.

@ryaeng
Copy link
Contributor Author

ryaeng commented Jun 24, 2022

Yes, but we're working toward an internal deadline and will likely not get to this until next week.

Lemme know if there's anything I can do to help.

@zephraph
Copy link
Contributor

zephraph commented Aug 5, 2022

Given we're not actively pursuing this at the moment and there are a lot of in-flight changes I'm going to close this. We can always re-open and revisit if later if we decide to.

@zephraph zephraph closed this Aug 5, 2022
leftwo added a commit that referenced this pull request Mar 29, 2024
Propolis changes:
Add `IntrPin::import_state` and migrate LPC UART pin states (#669)
Attempt to set WCE for raw file backends
Fix clippy/lint nits for rust 1.77.0

Crucible changes:
Correctly (and robustly) count bytes (#1237)
test-replay.sh fix name of DTrace script (#1235)
BlockReq -> BlockOp (#1234)
Simplify `BlockReq` (#1218)
DTrace, cmon, cleanup, retry downstairs connections at 10 seconds.
(#1231)
Remove `MAX_ACTIVE_COUNT` flow control system (#1217)

Crucible changes that were in Omicron but not in Propolis before this commit.
Return *410 Gone* if volume is inactive (#1232)
Update Rust crate opentelemetry to 0.22.0 (#1224)
Update Rust crate base64 to 0.22.0 (#1222)
Update Rust crate async-recursion to 1.1.0 (#1221)
Minor cleanups to extent implementations (#1230)
Update Rust crate http to 0.2.12 (#1220)
Update Rust crate reedline to 0.30.0 (#1227)
Update Rust crate rayon to 1.9.0 (#1226)
Update Rust crate nix to 0.28 (#1223)
Update Rust crate async-trait to 0.1.78 (#1219)
Various buffer optimizations (#1211)
Add low-level test for message encoding (#1214)
Don't let df failures ruin the buildomat tests (#1213)
Activate the NBD server's psuedo file (#1209)

---------

Co-authored-by: Alan Hanson <alan@oxide.computer>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants