-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Connect Crucible stats through Propolis to Oximeter #1347
Conversation
This commit makes the final step in plumbing metrics genrated in Crucible Upstairs through Propolis to Oximeter. Updated versions of both Crucible and Propolis are required (and they both require this update). Removed two fields of CrucibleOpts that are obsolete. Updates to supply a UUID to the VolumeConstructionRequest. It is currently just a random UUID, but that is how it was on the crucible side already, and this change will allow Nexus, when it is ready, to supply a real UUID. This change is not required for the metrics, but the change is already in the Crucible side, so it must be included when we update the Crucible rev. New git rev and packages for both Propolis and Crucible
@smklein I'd love your thoughts on how best to get the Nexus IP:Port into the |
Sorry for the delay on this. Let me pull the DNS utilities out of some of my larger patchsets, so they can be used by the sled agent. |
Done in #1386 |
Updated the sled-agent instance code to get the I.P. for Nexus from Crucible and Propolis changes are all back, and the package-manifest has been updated, so this is ready for |
This commit makes the final step in plumbing metrics generated in
Crucible Upstairs through Propolis to Oximeter. Updated versions
of both Crucible and Propolis are required (and they both require
this update).
Removed two fields in
CrucibleOpts
that are now obsolete.Some updates to supply a UUID to the
VolumeConstructionRequest
.It is currently just a random UUID, but that is how it was on the
crucible side already, and this change will allow Nexus, when it is
ready, to supply a real UUID. This change is not required for the
metrics, but the change is already in the Crucible side, so it
must be included when we update the Crucible rev.
New git rev and packages for both Propolis and Crucible
I'm not sure how to get the IP:Port for nexus down into the
sled-agent
setup_propolis_locked()
method. I was thinking eitherattach it to
InstanceInner
as a field, or add a method toNexusClient
that would return the IP:Port for thatNexusClient
.Neither way seems ideal. I'm open to other ideas.
Things that should happen before this goes in: