Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Connect Crucible stats through Propolis to Oximeter #1347

Merged
merged 6 commits into from
Jul 13, 2022
Merged

Connect Crucible stats through Propolis to Oximeter #1347

merged 6 commits into from
Jul 13, 2022

Conversation

leftwo
Copy link
Contributor

@leftwo leftwo commented Jul 2, 2022

This commit makes the final step in plumbing metrics generated in
Crucible Upstairs through Propolis to Oximeter. Updated versions
of both Crucible and Propolis are required (and they both require
this update).

Removed two fields in CrucibleOpts that are now obsolete.

Some updates to supply a UUID to the VolumeConstructionRequest.
It is currently just a random UUID, but that is how it was on the
crucible side already, and this change will allow Nexus, when it is
ready, to supply a real UUID. This change is not required for the
metrics, but the change is already in the Crucible side, so it
must be included when we update the Crucible rev.

New git rev and packages for both Propolis and Crucible

I'm not sure how to get the IP:Port for nexus down into the
sled-agent setup_propolis_locked() method. I was thinking either
attach it to InstanceInner as a field, or add a method to
NexusClient that would return the IP:Port for that NexusClient.
Neither way seems ideal. I'm open to other ideas.

Things that should happen before this goes in:

  • Propolis PR merged to main
  • Update the git rev and package file after the above merge to main
  • Figure out how to provide the Nexus IP:Port to propolis-server (fix the TODO)

This commit makes the final step in plumbing metrics genrated in
Crucible Upstairs through Propolis to Oximeter.  Updated versions
of both Crucible and Propolis are required (and they both require
this update).

Removed two fields of CrucibleOpts that are obsolete.

Updates to supply a UUID to the VolumeConstructionRequest.
It is currently just a random UUID, but that is how it was on the
crucible side already, and this change will allow Nexus, when it is
ready, to supply a real UUID. This change is not required for the
metrics, but the change is already in the Crucible side, so it
must be included when we update the Crucible rev.

New git rev and packages for both Propolis and Crucible
@leftwo leftwo requested a review from smklein July 2, 2022 03:57
@leftwo
Copy link
Contributor Author

leftwo commented Jul 2, 2022

@smklein I'd love your thoughts on how best to get the Nexus IP:Port into the update_propolis_locked() method, as I don't think what is there now can fly.

@iliana iliana mentioned this pull request Jul 2, 2022
3 tasks
@smklein
Copy link
Collaborator

smklein commented Jul 11, 2022

@smklein I'd love your thoughts on how best to get the Nexus IP:Port into the update_propolis_locked() method, as I don't think what is there now can fly.

Sorry for the delay on this. Let me pull the DNS utilities out of some of my larger patchsets, so they can be used by the sled agent.

@smklein
Copy link
Collaborator

smklein commented Jul 11, 2022

Done in #1386

@leftwo leftwo added storage Related to storage. Sled Agent Related to the Per-Sled Configuration and Management Remote Access Preview labels Jul 11, 2022
@leftwo
Copy link
Contributor Author

leftwo commented Jul 12, 2022

Updated the sled-agent instance code to get the I.P. for Nexus from lazy_nexus_client's get_ip() method

Crucible and Propolis changes are all back, and the package-manifest has been updated, so this is ready for
another review.

@leftwo leftwo merged commit 5fb8ece into main Jul 13, 2022
@leftwo leftwo deleted the upmetrics branch July 13, 2022 03:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Remote Access Preview Sled Agent Related to the Per-Sled Configuration and Management storage Related to storage.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants