Unrolling saga actions for external IPs and NICs #1474
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, for NICs and external IPs, the saga action that actually created the records and the corresponding undo were not together in a saga node. The undo was associated with a preceding action that created UUIDs for the records. That was because each action may have created multiple records, where the count was not known when we create the saga template, and so the forward action performed multiple fallible steps. To unwind it completely, including reverting the creation of N resources, in the case where the N + 1th failed, we put the undo in the preceding step. That worked, but was certainly confusing and bad for maintenance, since the action and its undo were in different nodes. It also resulted in a ton of extra complexity in some of the downstream queries, which now had to be aware of the fact that we might replay a partially-played saga node. This commit undoes all that. - Unroll the instance external IP address query - Unroll the network interface creation query - Actually delete NICs when we delete the instance, and add test for that - Simplify network interface query. An additional CTE detecting the partial-saga replay case is no longer needed, since we don't run the saga that way.
|
Resolves #1466 |
smklein
reviewed
Jul 22, 2022
- Create UUIDs in separate saga actions for NICs and external IPs - Remove remaining cruft from NIC-creation query that was required to handle the previous saga implementation.
smklein
approved these changes
Jul 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, for NICs and external IPs, the saga action that actually
created the records and the corresponding undo were not together in a
saga node. The undo was associated with a preceding action that created
UUIDs for the records. That was because each action may have created
multiple records, where the count was not known when we create the saga
template, and so the forward action performed multiple fallible steps.
To unwind it completely, including reverting the creation of N
resources, in the case where the N + 1th failed, we put the undo in the
preceding step. That worked, but was certainly confusing and bad for
maintenance, since the action and its undo were in different nodes. It
also resulted in a ton of extra complexity in some of the downstream
queries, which now had to be aware of the fact that we might replay a
partially-played saga node. This commit undoes all that.
that
partial-saga replay case is no longer needed, since we don't run the
saga that way.