Use crucible-client-types instead of crucible #1553
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of including the entire crucible library, use the new crucible-client-types crate that exports only the things that the sled-agent needs. Update crucible and propolis versions. Update Cargo.toml comment for propolis-client and crucible-client-types Added new field for CrucibleOpts
|
Verified I can still create an instance with crucible volumes. This should address #1537 |
smklein
approved these changes
Aug 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of including the entire crucible library, use the new
crucible-client-types crate that exports only the things that
the sled-agent needs.
Update crucible and propolis versions.
Update Cargo.toml comment for propolis-client and crucible-client-types
Added new field for CrucibleOpts