Do not accept IDP metadata documents without keys#3315
Merged
jmpesp merged 2 commits intooxidecomputer:mainfrom Jun 12, 2023
Merged
Do not accept IDP metadata documents without keys#3315jmpesp merged 2 commits intooxidecomputer:mainfrom
jmpesp merged 2 commits intooxidecomputer:mainfrom
Conversation
Do not initialize a SAML identity provider if the provided IDP metadata document does not have a signing key. The control plane must require and only accept signed assertions. Fixes oxidecomputer#3155
Contributor
|
This doesn't actually seem to change |
Contributor
Author
My mistake, I should have updated the issue: when @david-crespo and I were talking, I was referring to the IDP metadata signing key, not the SP (aka us) signing key. Our signing key can remain optional. |
Contributor
Author
|
(note I pushed up a test that was missing from our coverage) |
david-crespo
approved these changes
Jun 12, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Do not initialize a SAML identity provider if the provided IDP metadata document does not have a signing key. The control plane must require and only accept signed assertions.
Fixes #3155