Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename ssh_keys to ssh_public_keys in instance create #4941

Merged
merged 3 commits into from
Jan 31, 2024
Merged

Rename ssh_keys to ssh_public_keys in instance create #4941

merged 3 commits into from
Jan 31, 2024

Conversation

zephraph
Copy link
Contributor

Fixes #4866

@zephraph zephraph requested a review from david-crespo January 31, 2024 14:38
david-crespo
david-crespo approved these changes Jan 31, 2024
View reviewed changes
Copy link
Contributor

@david-crespo david-crespo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! If CI passes I figure we’re solid.

@zephraph zephraph merged commit 6491841 into main Jan 31, 2024
21 checks passed
@zephraph zephraph deleted the ssh-keys-rename branch January 31, 2024 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@david-crespo david-crespo david-crespo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rename ssh_key to ssh_public_key
2 participants
@zephraph @david-crespo