[1/6] [oximeter] split oximeter-impl into -types, -schema and -test-utils #6355
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Created using spr 1.3.6-beta.1
Contributor
Author
|
Oh need to update doctests too. |
Created using spr 1.3.6-beta.1
bnaecker
approved these changes
Aug 16, 2024
Collaborator
bnaecker
left a comment
bnaecker
left a comment
There was a problem hiding this comment.
Looks good, thanks for cleaning it up with minimal fuss! I have a few questions, but they're really just informational, not blocking the PR. Thanks!
Created using spr 1.3.6-beta.1
Created using spr 1.3.6-beta.1
sunshowers
added a commit
to sunshowers/omicron
that referenced
this pull request
Aug 17, 2024
The Nexus external API uses several types from oximeter, and in the interest of keeping the upcoming nexus-external-api crate's graph small, it makes sense to split it into three crates. The crates are: * **oximeter-types**: Core type definitions (there are a lot of them). * **oximeter-schema**: Library for working with schemas. * **oximeter-test-utils**: Test utilities. The names match the other services in omicron, e.g. `sled-agent-types` and `nexus-test-utils`. Pull Request: oxidecomputer#6355
sunshowers
changed the title
sunshowers
deleted the
sunshowers/spr/oximeter-split-oximeter-impl-into-types-schema-and-test-utils
branch
sunshowers
added a commit
that referenced
this pull request
Aug 28, 2024
At long last, here's the last OpenAPI document converted into a trait: the Nexus external API. This is a fairly large change, but with all the prerequisites in place the conversion is overall pretty mechanical. I did need to move some types around, but the bulk of the PR is just adding the very large external API trait. This PR also adds a `.git-blame-ignore-revs` entry corresponding to #6372, so that the indent doesn't ruin blame in the GitHub web view. (You can configure this locally as well with `git config blame.ignoreRevsFile .git-blame-ignore-revs`.) In a subsequent PR I'll remove the old instructions. Depends on: * #6355 * #6364 * #6369 * #6370 * #6372 Co-authored-by: David Crespo <david.crespo@oxidecomputer.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Nexus external API uses several types from oximeter, and in the interest of
keeping the upcoming nexus-external-api crate's graph small, it makes sense to
split it into three crates.
The crates are:
The names match the other services in omicron, e.g.
sled-agent-typesandnexus-test-utils.