Make OxQL query response type into an object #6374
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
bnaecker
commented
Aug 17, 2024
bnaecker
commented
- Fixes Type returned from OxQL queries should be an object #6371
david-crespo
approved these changes
Aug 17, 2024
Contributor
david-crespo
left a comment
david-crespo
left a comment
There was a problem hiding this comment.
Looks good! I think with #6373, OxqlQueryResult will have to live in nexus/types/src/external_api/views.rs, so you might as well move it there already.
Collaborator
Author
|
Makes sense, thanks. @sunshowers should I wait until the Nexus external API sequence lands to merge this? It's not a big conflict, but I don't want to hold the train. |
sunshowers
reviewed
Aug 17, 2024
Contributor
sunshowers
left a comment
sunshowers
left a comment
There was a problem hiding this comment.
How about landing this after #6364? (That will cause a semantic merge conflict with this PR sadly.) The rest are pretty easy to fix up, thanks!
bnaecker
force-pushed
the
return-object-from-oxql-query
branch
from
f1fddda to
27ff09e
Compare
Collaborator
Author
|
I've updated this on Rain's #6364, and set this to automerge. Thanks for the reviews y'all!. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.