[reconfigurator] add decommissioned sleds to the planning input #6644
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Created using spr 1.3.6-beta.1
Created using spr 1.3.6-beta.1
sunshowers
changed the title
smklein
approved these changes
Sep 24, 2024
| let sled_rows = datastore | ||
| .sled_list_all_batched(opctx, SledFilter::Commissioned) | ||
| .sled_list_all_batched(opctx, SledFilter::All) |
There was a problem hiding this comment.
Just to confirm:
It seems like we could infer that a sled is decommissioned by seeing "a trace of it exists in the blueprint, but it is absent from the planning input".
Is this decision to make things explicit a safety-guard? Just trying to check my understanding whether this is "truly a necessity" or "an explicit alternative to relying on implied state".
There was a problem hiding this comment.
Yes, it's meant to be a safety guard specifically for cleanup -- because zone cleanup will actually remove entries from the blueprint. So it's possible that if a sled is missed somehow then it disappears from the blueprint (I actually first realized this while writing tests for Nexus zone cleanup).
Created using spr 1.3.6-beta.1
sunshowers
deleted the
sunshowers/spr/reconfigurator-also-return-decommissioned-sleds-as-part-of-the-planning-input
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With zone cleanup, part of the logic depends on knowing whether particular sleds are decommissioned. Previously we weren't returning such sleds at all, which means that the planner is unable to distinguish between the cases where the sled is decommissioned and the sled is not present in the input at all. (It would be really bad for zone cleanup to remove zones if something went horribly wrong!)
There is the potential for some fallout from decommissioned entries being present in the sled map -- I've tried to guard it best I can by changing the lookup API making it accept a filter. An alternative would be to store the set of decommissioned sleds separately, but that seems worse long-term.
The change identified a small issue with the reconfigurator CLI -- previously, we'd be okay overwriting decommissioned sleds. That case produces a soft error now.