replace TUF artifact primary key with a UUID #7340
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sunshowers
approved these changes
Jan 14, 2025
| @@ -1014,8 +1013,7 @@ authz_resource! { | |||
| authz_resource! { | |||
| name = "TufArtifact", | |||
| parent = "Fleet", | |||
| primary_key = (String, SemverVersion, String), | |||
| input_key = ArtifactId, | |||
| primary_key = { uuid_kind = TufArtifactKind }, | |||
uuid-kinds/src/lib.rs
Outdated
| TufRepo => "tuf_repo", | ||
| TufArtifact => "tuf_artifact", |
iliana
force-pushed
the
iliana/tuf-artifact-key
branch
from
b84aaea to
5c5c53f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(name, version, kind)is a natural key for thetuf_artifacttable: given a kind and name for an artifact, we should only ever have one copy of any particular version.However, this natural key does not distribute well, which makes it a poor choice for a primary key in CockroachDB. It also makes pagination more difficult.
Instead of altering the schema we drop the tables and recreate them, as any potential contents would be useless to us; until #7129 lands we have no means to store the artifacts from a repository.