Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(3/5) [nexus] Add CRUD implementations for Affinity/Anti-Affinity Groups #7445

Open
wants to merge 9 commits into
base: affinity-db-model
Choose a base branch
from
Open

(3/5) [nexus] Add CRUD implementations for Affinity/Anti-Affinity Groups #7445

wants to merge 9 commits into from
+2,959 −1

Conversation

smklein
Copy link
Collaborator

@smklein smklein commented Jan 30, 2025

Pulled out of #7076

Adds auth structures for Affinity/Anti-Affinity Groups, as well as datastore methods for implementing
CRUD (Create, Read, Update Delete) methods on these groups.

@smklein smklein mentioned this pull request Jan 30, 2025
Open
44 tasks
@smklein smklein requested review from hawkw and gjcolombo January 30, 2025 21:24
hawkw
hawkw reviewed Jan 31, 2025
View reviewed changes
Copy link
Member

@hawkw hawkw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing too controversial here, and I like the large number of tests! I had a couple smallish thoughts I commented on.

nexus/db-queries/src/db/datastore/affinity.rs Show resolved Hide resolved
nexus/db-queries/src/db/datastore/affinity.rs Show resolved Hide resolved
nexus/db-queries/src/db/datastore/affinity.rs Outdated Show resolved Hide resolved
andrewjstone
andrewjstone approved these changes Jan 31, 2025
View reviewed changes
Copy link
Contributor

@andrewjstone andrewjstone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Thanks for the comprehensive tests.

@gjcolombo gjcolombo mentioned this pull request Feb 3, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewjstone andrewjstone andrewjstone approved these changes

@gjcolombo gjcolombo gjcolombo approved these changes

@hawkw hawkw hawkw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@smklein @andrewjstone @hawkw @gjcolombo