[internal-dns] Shove service discovery into a zone #807
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smklein
commented
Mar 24, 2022
smf/internal-dns/config.toml
Outdated
| @@ -0,0 +1,22 @@ | |||
| [dropshot] | |||
| bind_address = "[fd00:1234::4]:5353" | |||
There was a problem hiding this comment.
These addresses are totally made-up -- I have some follow-up work to incorporate the subnets of the physical network described in RFD 63 into this repo.
smklein
commented
Mar 24, 2022
smf/sled-agent/config-rss.toml
Outdated
Comment on lines
42
to
44
| [[request.service]] | ||
| name = "internal-dns" | ||
| addresses = [ "[fd00:1234::4]:5353" ] |
There was a problem hiding this comment.
FYI, with this addition, the RSS spins up an "internal-dns" zone on this Sled.
I confirmed that this service is running and accessible by using:
cargo run --bin dnsadm -- -a [fd00:1234::4] list-records
davepacheco
reviewed
Mar 24, 2022
| @@ -0,0 +1,36 @@ | |||
| <?xml version="1.0"?> | |||
There was a problem hiding this comment.
I assume this is following a pattern of other services. Has @jclulow taken a look at this?
There was a problem hiding this comment.
We have a variety of XML files under smf in Omicron, if you wanna compare:
./nexus/manifest.xml
./oximeter/manifest.xml
./cockroachdb/manifest.xml
./clickhouse/manifest.xml
./sled-agent/manifest.xml
smf/sled-agent/config-rss.toml
Outdated
Comment on lines
42
to
44
| [[request.service]] | ||
| name = "internal-dns" | ||
| addresses = [ "[fd00:1234::4]:5353" ] |
17 tasks
rcgoodfellow
approved these changes
Apr 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds on #800 , actually launching the internal DNS subsystem as a Zone.
Part of #718