Skip to content

Capture SP task dumps in support bundles #8177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
May 23, 2025
Merged

Capture SP task dumps in support bundles #8177

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
dbb6669
Capture SP task dumps in support bundles
wfchandler May 16, 2025
50457f7
Merge branch 'main' into wc/bundle-sp-dumps
wfchandler May 21, 2025
fc341e1
Switch to ParallelTaskSet and show SPs in report
wfchandler May 21, 2025
132e7bb
Assert sp dump dir is created
wfchandler May 21, 2025
6b2892d
Fix name assertion
wfchandler May 21, 2025
7cb6043
Immediately await the SP dump task
wfchandler May 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions dev-tools/omdb/src/bin/omdb/nexus.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2347,6 +2347,7 @@ fn print_task_support_bundle_collector(details: &serde_json::Value) {
if let Some(SupportBundleCollectionReport {
bundle,
listed_in_service_sleds,
listed_sps,
activated_in_db_ok,
}) = collection_report
{
Expand All @@ -2355,6 +2356,9 @@ fn print_task_support_bundle_collector(details: &serde_json::Value) {
println!(
" Bundle was able to list in-service sleds: {listed_in_service_sleds}"
);
println!(
" Bundle was able to list service processors: {listed_sps}"
);
println!(
" Bundle was activated in the database: {activated_in_db_ok}"
);
Expand Down
1 change: 1 addition & 0 deletions nexus/src/app/background/init.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -505,6 +505,7 @@ impl BackgroundTasksInitializer {
task_impl: Box::new(
support_bundle_collector::SupportBundleCollector::new(
datastore.clone(),
resolver.clone(),
Copy link
Contributor Author

@wfchandler wfchandler May 20, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe this isn't the best approach, given the conversation in the control plane huddle today. On the other hand, we're very unlikely to be collecting bundles fast enough to have a real impact.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine to punt on this until we sort out the progenitor integration with qorb more holistically

config.support_bundle_collector.disable,
nexus_id,
),
Expand Down
Loading
Loading