Skip to content

Conversation

@bnaecker
Copy link
Collaborator

Fixes #6825

@bnaecker bnaecker requested a review from david-crespo July 10, 2025 16:09
Copy link
Contributor

@david-crespo david-crespo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I foresee no issues

@david-crespo
Copy link
Contributor

david-crespo commented Jul 10, 2025

Helios tests flaked on integration_tests::crucible_replacements::test_region_snapshot_replacement_step_after_rop_remove_target_gone. Made issue #8568 for that.

https://buildomat.eng.oxide.computer/wg/0/details/01JZTHHRW0Z4XZNP2QDAN725NX/vRd388kKuDNEoacSDWR6JkiVQpK7Y1RfB54em22tE0W2iZc0/01JZTHJ39YNFMEJJZ02VVW1R7Y

@david-crespo david-crespo merged commit e4b4420 into main Jul 10, 2025
17 checks passed
@david-crespo david-crespo deleted the ephemeral-ip-include-pool branch July 10, 2025 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Ephemeral IPs in instance IPs list should include pool ID

3 participants