[DNM] attempt to use a semaphore to work around opte 758 #9214
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an incomplete attempt to use a semaphore with one permit, to prevent kstat reads and XDE ioctls from happening simultaneously, with the goal of working around oxidecomputer/opte#758 (see #9211).
What's missing:
illumos_utils::opte::PortInner
(aPort
is anArc
around this) callsdelete_xde
, which would need to be protected by the same semaphore.Unfortunately this is becoming complicated and fragile enough that I've become significantly less optimistic about using this path as a workaround, compared to the alternative where:
In particular, the requirement to pass the semaphore into the
PortInner
and lock it inside the generally-unobservableDrop
impl has me quite concerned.Putting this up there for folks to look at in the meantime.