Update gateway-messages and bundled faux-mgs
#9354
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In particular, this picks up oxidecomputer/management-gateway-service#451 and oxidecomputer/management-gateway-service#452, which we'd like for debugging hung sled issues. To make this easier to backport to the R17 release branch, it makes minimal changes: requesting these new types of component details from MGS proper will return a 400 (albeit one that probably contains all the details we actually want in the error message!), because returning a 200 would require revving the MGS OpenAPI. The control plane has no logic to collect this information yet, so I think this is fine - it'll be available to support via `faux-mgs` as we'd like, and I'll file an issue for adding proper MGS support at our convenience.
labbott
approved these changes
Nov 6, 2025
Contributor
labbott
left a comment
labbott
left a comment
There was a problem hiding this comment.
LGTM as far as code review goes
Contributor
Author
|
The test failure on the original version of the PR is because oxidecomputer/management-gateway-service#457 accidentally broke the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In particular, this picks up
oxidecomputer/management-gateway-service#451 and oxidecomputer/management-gateway-service#452, which we'd like for debugging hung sled issues.
To make this easier to backport to the R17 release branch, it makes minimal changes: requesting these new types of component details from MGS proper will return a 400 (albeit one that probably contains all the details we actually want in the error message!), because returning a 200 would require revving the MGS OpenAPI. The control plane has no logic to collect this information yet, so I think this is fine - it'll be available to support via
faux-mgsas we'd like, and I'll file an issue for adding proper MGS support at our convenience.