Add Blippy::check_against_planning_input()
#9356
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sunshowers
reviewed
Nov 6, 2025
Comment on lines
585
to
597
| pub fn new(blueprint: &'a Blueprint) -> Self { | ||
| let mut slf = Self { blueprint, notes: Vec::new() }; | ||
| checks::perform_all_blueprint_only_checks(&mut slf); | ||
| slf | ||
| } | ||
|
|
||
| pub fn check_against_planning_input( | ||
| mut self, | ||
| input: &PlanningInput, | ||
| ) -> Self { | ||
| checks::perform_planning_input_checks(&mut self, input); | ||
| self | ||
| } |
Contributor
There was a problem hiding this comment.
Thoughts on changing Blippy::new to accept a PlanningInput and adding a new_without_planning_input constructor for the rare cases such as RSS where that isn't available?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new method to (optionally) check a blueprint against a given planning input. The only check included in this PR is a line-for-line port of the builder's
ensure_input_networking_records_appear_in_parent_blueprint()function (which I'm removing from the builder in #9347). I updated most of theBlippycall sites to use this method; I skipped the one in an RSS test because it has no planning input available - RSS just generates a raw blueprint to hand off to Nexus.