Swap how to refer to the new instance ensure body#9408
Closed
jmpesp wants to merge 1 commit intooxidecomputer:mainfrom
Closed
Swap how to refer to the new instance ensure body#9408jmpesp wants to merge 1 commit intooxidecomputer:mainfrom
jmpesp wants to merge 1 commit intooxidecomputer:mainfrom
Conversation
Instead of using a v7 module to refer to the new instance ensure body, use a v6 module to refer to the old one - eventually we'll want to deprecate and remove the old instance ensure body type, and it's easier to refer to the old type in the few places that it's required to. This commit also removes `multicast_cross_version_works` because I don't think it's necessary now that we're sending (and routing based on!) the api version header.
Contributor
Author
|
duplicate of #9407 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of using a v7 module to refer to the new instance ensure body, use a v6 module to refer to the old one - eventually we'll want to deprecate and remove the old instance ensure body type, and it's easier to refer to the old type in the few places that it's required to.
This commit also removes
multicast_cross_version_worksbecause I don't think it's necessary now that we're sending (and routing based on!) the api version header.