[clickhouse-admin-types] reorganize per RFD 619#9523
Merged
sunshowers merged 4 commits intomainfrom Dec 18, 2025
Merged
Conversation
Created using spr 1.3.6-beta.1
Created using spr 1.3.6-beta.1
Created using spr 1.3.6-beta.1
25 tasks
karencfv
reviewed
Dec 17, 2025
Contributor
karencfv
left a comment
karencfv
left a comment
There was a problem hiding this comment.
Just left a note about a module, but apart from that looks good. Thanks for the last minute push to get all of these in!
Created using spr 1.3.6-beta.1
karencfv
approved these changes
Dec 17, 2025
Contributor
There was a problem hiding this comment.
This is more of a question for my own understanding. Why is there a separate impls module instead of having the impls live with their type in each version module?
Contributor
Author
There was a problem hiding this comment.
This is so that if you change a type, the implementations get carried forward to the new version without you having to copy code around. (In some cases you might need some of these methods on prior versions, but we hope/expect that that is uncommon -- and in that case, you can copy those methods and put them next to the prior version.)
sunshowers
deleted the
sunshowers/spr/clickhouse-admin-types-reorganize-per-rfd-619
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.